Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issue 585913003: Improve sign-in error UX. (Closed)

Created:
6 years, 3 months ago by Jamie
Modified:
6 years, 3 months ago
Reviewers:
garykac1, garykac
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Improve sign-in error UX. If the user cancels their sign-in, or if some other error occurs, we currently display "An unknown error occurred", which is not very helpful. Committed: https://crrev.com/7c4333a67594fc58d9a88caab055c96e9064597a Cr-Commit-Position: refs/heads/master@{#295800}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M remoting/webapp/identity.js View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Jamie
ptal
6 years, 3 months ago (2014-09-19 21:33:44 UTC) #2
garykac1
lgtm
6 years, 3 months ago (2014-09-19 21:35:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/585913003/1
6 years, 3 months ago (2014-09-19 21:41:50 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/585913003/1
6 years, 3 months ago (2014-09-19 21:41:57 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as d463f6b84e8a56d44904ec1418c99d7b47ea26dc
6 years, 3 months ago (2014-09-19 23:18:17 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-19 23:19:18 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7c4333a67594fc58d9a88caab055c96e9064597a
Cr-Commit-Position: refs/heads/master@{#295800}

Powered by Google App Engine
This is Rietveld 408576698