Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(549)

Unified Diff: remoting/webapp/identity.js

Issue 585913003: Improve sign-in error UX. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/webapp/identity.js
diff --git a/remoting/webapp/identity.js b/remoting/webapp/identity.js
index ebf3dd7f4d91f4c98c913310ae0a24131d16cd30..b7507749e6e37d0cdbf69003456154eb98b03705 100644
--- a/remoting/webapp/identity.js
+++ b/remoting/webapp/identity.js
@@ -124,13 +124,12 @@ remoting.Identity.prototype.onAuthComplete_ = function(interactive, token) {
// If not, pass an error back to the callback(s) if we've already prompted the
// user for permission.
- // TODO(jamiewalch): Figure out what to do with the error in this case.
if (interactive) {
console.error(chrome.runtime.lastError);
while (this.pendingCallbacks_.length > 0) {
var callback = /** @type {remoting.Identity.Callbacks} */
this.pendingCallbacks_.shift();
- callback.onError(remoting.Error.UNEXPECTED);
+ callback.onError(remoting.Error.NOT_AUTHENTICATED);
}
return;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698