Issue 585913002: fail early if coincidence can't be resolved

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 585913002: fail early if coincidence can't be resolved (Closed)

Created:
6 years, 3 months ago by caryclark

Modified:
6 years, 3 months ago

Reviewers:

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

fail early if coincidence can't be resolved Bail out if a very large value causes coincidence resolution to fail. TBR= BUG=415866 Committed: https://skia.googlesource.com/skia/+/630240d18805faf81d8e75172496ad165c2226b2

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+300 lines, -91 lines)			Patch
M	src/pathops/SkAddIntersections.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pathops/SkAddIntersections.cpp	View	2 chunks	+5 lines, -2 lines	0 comments	Download
M	src/pathops/SkOpContour.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/pathops/SkOpContour.cpp	View	5 chunks	+16 lines, -11 lines	0 comments	Download
M	src/pathops/SkOpSegment.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pathops/SkOpSegment.cpp	View	7 chunks	+11 lines, -7 lines	0 comments	Download
M	src/pathops/SkPathOpsCommon.cpp	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	tests/PathOpsOpTest.cpp	View	2 chunks	+95 lines, -1 line	0 comments	Download
M	tools/pathops_visualizer.htm	View	2 chunks	+166 lines, -65 lines	0 comments	Download

Total messages: 3 (1 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/585913002/1

6 years, 3 months ago (2014-09-19 13:25:18 UTC) #2

commit-bot: I haz the power

6 years, 3 months ago (2014-09-19 13:33:34 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) as 630240d18805faf81d8e75172496ad165c2226b2