src/pathops/SkPathOpsCommon.cpp - Issue 585913002: fail early if coincidence can't be resolved

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/pathops/SkPathOpsCommon.cpp

Issue 585913002: fail early if coincidence can't be resolved (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/pathops/SkPathOpsCommon.cpp

diff --git a/src/pathops/SkPathOpsCommon.cpp b/src/pathops/SkPathOpsCommon.cpp

index 9a8a2cf4e31dcd269d624b8a5d7664bcf87d5f8a..f7b7273a8d0cf3676a44c414b575e3877c22e66d 100644

--- a/src/pathops/SkPathOpsCommon.cpp

+++ b/src/pathops/SkPathOpsCommon.cpp

@@ -699,7 +699,9 @@ bool HandleCoincidence(SkTArray<SkOpContour*, true>* contourList, int total) {

#if DEBUG_SHOW_WINDING

SkOpContour::debugShowWindingValues(contourList);

#endif

- CoincidenceCheck(contourList, total);

+ if (!CoincidenceCheck(contourList, total)) {

+ return false;

+ }

#if DEBUG_SHOW_WINDING

SkOpContour::debugShowWindingValues(contourList);

#endif

« no previous file with comments | « src/pathops/SkOpSegment.cpp ('k') | tests/PathOpsOpTest.cpp » ('j') | no next file with comments »