Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 585893002: Refactoring: Use fake cwd in release script tests. (Closed)

Created:
6 years, 3 months ago by Michael Achenbach
Modified:
6 years, 3 months ago
Reviewers:
tandrii(chromium)
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Refactoring: Use fake cwd in release script tests. TEST=script_test.py R=tandrii@chromium.org TBR=jarin@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24086

Patch Set 1 #

Patch Set 2 : Remove git location legacy. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -25 lines) Patch
M tools/push-to-trunk/auto_push.py View 1 2 chunks +1 line, -2 lines 0 comments Download
M tools/push-to-trunk/auto_tag.py View 1 1 chunk +0 lines, -1 line 0 comments Download
M tools/push-to-trunk/chromium_roll.py View 1 2 chunks +1 line, -2 lines 0 comments Download
M tools/push-to-trunk/common_includes.py View 1 2 chunks +2 lines, -3 lines 0 comments Download
M tools/push-to-trunk/merge_to_branch.py View 1 2 chunks +1 line, -2 lines 0 comments Download
M tools/push-to-trunk/push_to_trunk.py View 1 2 chunks +1 line, -2 lines 0 comments Download
M tools/push-to-trunk/releases.py View 1 1 chunk +0 lines, -1 line 0 comments Download
M tools/push-to-trunk/test_scripts.py View 1 11 chunks +11 lines, -12 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Michael Achenbach
PTAL
6 years, 3 months ago (2014-09-19 11:16:01 UTC) #2
tandrii(chromium)
LGTM
6 years, 3 months ago (2014-09-19 11:43:41 UTC) #3
Michael Achenbach
More clean ups... more to come...
6 years, 3 months ago (2014-09-19 11:43:58 UTC) #4
tandrii(chromium)
This one also LG
6 years, 3 months ago (2014-09-19 13:00:42 UTC) #5
Michael Achenbach
I think LG is enough for this one :)
6 years, 3 months ago (2014-09-19 13:37:08 UTC) #6
Michael Achenbach
6 years, 3 months ago (2014-09-19 13:37:53 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 24086 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698