tools/push-to-trunk/common_includes.py - Issue 585893002: Refactoring: Use fake cwd in release script tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/push-to-trunk/common_includes.py

Issue 585893002: Refactoring: Use fake cwd in release script tests. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Remove git location legacy. Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/push-to-trunk/common_includes.py

diff --git a/tools/push-to-trunk/common_includes.py b/tools/push-to-trunk/common_includes.py

index 5f2eff4553e9e99fd8231f4d59740aece89bdd8b..d33c539bc0683a5e9ecfb8f864d1f13a5472d0fb 100644

--- a/tools/push-to-trunk/common_includes.py

+++ b/tools/push-to-trunk/common_includes.py

@@ -47,7 +47,6 @@ from git_recipes import GitFailedException

PERSISTFILE_BASENAME = "PERSISTFILE_BASENAME"

BRANCHNAME = "BRANCHNAME"

-DOT_GIT_LOCATION = "DOT_GIT_LOCATION"

VERSION_FILE = "VERSION_FILE"

CHANGELOG_FILE = "CHANGELOG_FILE"

CHANGELOG_ENTRY_FILE = "CHANGELOG_ENTRY_FILE"

@@ -414,9 +413,9 @@ class Step(GitRecipesMixin):

msg = "Can't continue. Please delete branch %s and try again." % name

self.Die(msg)

- def InitialEnvironmentChecks(self):

+ def InitialEnvironmentChecks(self, cwd):

# Cancel if this is not a git checkout.

- if not os.path.exists(self._config[DOT_GIT_LOCATION]): # pragma: no cover

+ if not os.path.exists(os.path.join(cwd, ".git")): # pragma: no cover

self.Die("This is not a git checkout, this script won't work for you.")

# Cancel if EDITOR is unset or not executable.

« no previous file with comments | « tools/push-to-trunk/chromium_roll.py ('k') | tools/push-to-trunk/merge_to_branch.py » ('j') | no next file with comments »