[Password Manager] Resolved lint errors reported on pre-submit (Clean-up).

[Password Manager] Resolved lint errors reported on pre-submit (Clean-up).

BUG=none

Committed: https://crrev.com/77453022c213b91001e50d4e976fbf9792868bdd
Cr-Commit-Position: refs/heads/master@{#295723}

[Pritam Nikam, 2014-09-19 10:11:52]

pritam.nikam@samsung.com changed reviewers:
+ vabr@chromium.org

[Pritam Nikam, 2014-09-19 10:11:53]

Hi Vaclav,

this is clean-up LC for lint errors on pre-submit. PTAL.

Thanks!

[vabr (Chromium), 2014-09-19 11:39:31]

Hi Pritam Nikam,

Thank you!
LGTM with some comments.

Cheers,
Vaclav

https://codereview.chromium.org/585883002/diff/1/components/password_manager/...
File components/password_manager/core/browser/password_manager.cc (right):

https://codereview.chromium.org/585883002/diff/1/components/password_manager/...
components/password_manager/core/browser/password_manager.cc:7: #include
<string>
This should actually already go to
components/password_manager/core/browser/password_manager.h, because std::string
is used in the signatures declared there. Once you do that, you no longer need
to #include <string> in the .cc file and the _unittest.cc file
(http://google-styleguide.googlecode.com/svn/trunk/cppguide.html#Names_and_Ord...
says: "However, any includes present in the related header do not need to be
included again in the related cc (i.e., foo.cc can rely on foo.h's includes).")

https://codereview.chromium.org/585883002/diff/1/components/password_manager/...
File components/password_manager/core/browser/password_manager_unittest.cc
(right):

https://codereview.chromium.org/585883002/diff/1/components/password_manager/...
components/password_manager/core/browser/password_manager_unittest.cc:16:
#include "components/password_manager/core/browser/password_manager.h"
While at it, please move this include up to be the very first one (and separate
it with a blank line from the standard library #includes following it). This is
according to
http://google-styleguide.googlecode.com/svn/trunk/cppguide.html#Names_and_Ord....

[Pritam Nikam, 2014-09-19 12:26:00]

Thanks Vaclav for review.

PTAL at patch set #2.

Thanks!

https://codereview.chromium.org/585883002/diff/1/components/password_manager/...
File components/password_manager/core/browser/password_manager.cc (right):

https://codereview.chromium.org/585883002/diff/1/components/password_manager/...
components/password_manager/core/browser/password_manager.cc:7: #include
<string>
On 2014/09/19 11:39:31, vabr (Chromium) wrote:
> This should actually already go to
> components/password_manager/core/browser/password_manager.h, because
std::string
> is used in the signatures declared there. Once you do that, you no longer need
> to #include <string> in the .cc file and the _unittest.cc file
>
(http://google-styleguide.googlecode.com/svn/trunk/cppguide.html#Names_and_Ord...
> says: "However, any includes present in the related header do not need to be
> included again in the related cc (i.e., foo.cc can rely on foo.h's
includes).")

Done.

https://codereview.chromium.org/585883002/diff/1/components/password_manager/...
File components/password_manager/core/browser/password_manager_unittest.cc
(right):

https://codereview.chromium.org/585883002/diff/1/components/password_manager/...
components/password_manager/core/browser/password_manager_unittest.cc:16:
#include "components/password_manager/core/browser/password_manager.h"
On 2014/09/19 11:39:31, vabr (Chromium) wrote:
> While at it, please move this include up to be the very first one (and
separate
> it with a blank line from the standard library #includes following it). This
is
> according to
>
http://google-styleguide.googlecode.com/svn/trunk/cppguide.html#Names_and_Ord....

Done.

[Pritam Nikam, 2014-09-19 13:05:07]

The CQ bit was checked by pritam.nikam@samsung.com

[commit-bot: I haz the power, 2014-09-19 13:06:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/585883002/20001

[vabr (Chromium), 2014-09-19 13:13:13]

Still LGTM, thanks.
Vaclav

https://codereview.chromium.org/585883002/diff/20001/components/password_mana...
File components/password_manager/core/browser/password_manager_unittest.cc
(right):

https://codereview.chromium.org/585883002/diff/20001/components/password_mana...
components/password_manager/core/browser/password_manager_unittest.cc:7:
#include <string>
optional nit: due to the include in the header file, you did not need to
#include <string> here again (see the citation from the code style guide in my
previous comment).
But feel free to keep it as is for now, this is really a minor thing.

[commit-bot: I haz the power, 2014-09-19 15:07:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-19 15:07:05]

Exceeded time limit waiting for builds to trigger.

[Pritam Nikam, 2014-09-19 17:04:42]

The CQ bit was checked by pritam.nikam@samsung.com

[commit-bot: I haz the power, 2014-09-19 17:05:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/585883002/20001

[commit-bot: I haz the power, 2014-09-19 17:19:21]

Committed patchset #2 (id:20001) as ae77b6c5df003f361a361dc53f8e787e6c20b56f

[commit-bot: I haz the power, 2014-09-19 17:20:09]

Patchset 2 (id:??) landed as
https://crrev.com/77453022c213b91001e50d4e976fbf9792868bdd
Cr-Commit-Position: refs/heads/master@{#295723}