components/password_manager/core/browser/password_form_manager.cc - Issue 585883002: [Password Manager] Resolved lint errors reported on pre-submit (Clean-up).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/password_form_manager.cc

Issue 585883002: [Password Manager] Resolved lint errors reported on pre-submit (Clean-up). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Incorporated review inputs. Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View side-by-side diff with in-line comments

« no previous file with comments | « no previous file | components/password_manager/core/browser/password_manager.h » ('j') | components/password_manager/core/browser/password_manager_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/password_form_manager.cc

diff --git a/components/password_manager/core/browser/password_form_manager.cc b/components/password_manager/core/browser/password_form_manager.cc

index dfe94a3533c2f86668d1b09fc42d59aeaffc69f9..b0cac81b8673daa22366df6fe199432f764ced3f 100644

--- a/components/password_manager/core/browser/password_form_manager.cc

+++ b/components/password_manager/core/browser/password_form_manager.cc

@@ -5,6 +5,7 @@

#include "components/password_manager/core/browser/password_form_manager.h"

#include <algorithm>

+#include <set>

#include "base/metrics/histogram.h"

#include "base/metrics/user_metrics.h"

@@ -95,7 +96,7 @@ PasswordFormManager::~PasswordFormManager() {

int PasswordFormManager::GetActionsTaken() {

return user_action_ + kUserActionMax * (manager_action_ +

kManagerActionMax * submit_result_);

-};

// TODO(timsteele): use a hash of some sort in the future?

PasswordFormManager::MatchResultMask PasswordFormManager::DoesManage(