Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 585643003: [Sync] Fix error handling during startup scenarios (Closed)

Created:
6 years, 3 months ago by Nicolas Zea
Modified:
6 years, 2 months ago
Reviewers:
maniscalco
CC:
chromium-reviews, tim+watch_chromium.org, haitaol+watch_chromium.org, zea+watch_chromium.org, maniscalco+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[Sync] Fix error handling during startup scenarios Two cases are now improved: 1. Errors during model loading. Previously this would trigger a reconfiguration despite being in the middle of an existing configuration. 2. Errors after model loading but before association. Previously these would do nothing. BUG=415757 Committed: https://crrev.com/2a445408e65baff94fb748f03ce30f76e09c60bc Cr-Commit-Position: refs/heads/master@{#296011}

Patch Set 1 #

Patch Set 2 : Add another test #

Patch Set 3 : Fix test #

Messages

Total messages: 8 (3 generated)
Nicolas Zea
PTAL
6 years, 3 months ago (2014-09-19 20:17:44 UTC) #3
maniscalco
lgtm
6 years, 2 months ago (2014-09-22 16:52:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/585643003/60001
6 years, 2 months ago (2014-09-22 17:10:55 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:60001) as 5dcd4a0309cede8ef62b8053a4e14e8342da15a8
6 years, 2 months ago (2014-09-22 18:09:22 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-09-22 18:09:56 UTC) #8
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/2a445408e65baff94fb748f03ce30f76e09c60bc
Cr-Commit-Position: refs/heads/master@{#296011}

Powered by Google App Engine
This is Rietveld 408576698