components/sync_driver/non_ui_data_type_controller_unittest.cc - Issue 585643003: [Sync] Fix error handling during startup scenarios

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/sync_driver/non_ui_data_type_controller_unittest.cc

Issue 585643003: [Sync] Fix error handling during startup scenarios (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix test Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/sync_driver/non_ui_data_type_controller_unittest.cc

diff --git a/components/sync_driver/non_ui_data_type_controller_unittest.cc b/components/sync_driver/non_ui_data_type_controller_unittest.cc

index 3f9e87ba4fe114418c1e6e35ebbb94326f7c9d1d..5eef2e3f8ca2768e99e9d6d437c6d11a258a56e2 100644

--- a/components/sync_driver/non_ui_data_type_controller_unittest.cc

+++ b/components/sync_driver/non_ui_data_type_controller_unittest.cc

@@ -486,7 +486,7 @@ TEST_F(SyncNonUIDataTypeControllerTest, OnSingleDataTypeUnrecoverableError) {

EXPECT_EQ(DataTypeController::RUNNING, non_ui_dtc_->state());

testing::Mock::VerifyAndClearExpectations(&start_callback_);

- EXPECT_CALL(start_callback_, Run(DataTypeController::RUNTIME_ERROR, _, _));

+ EXPECT_CALL(model_load_callback_, Run(_, _));

syncer::SyncError error(FROM_HERE,

syncer::SyncError::DATATYPE_ERROR,

"error",