Issue 585633004: Mojo: Add a MessageInTransit::Swap() method and remove the "PassContents" ctor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 585633004: Mojo: Add a MessageInTransit::Swap() method and remove the "PassContents" ctor. (Closed)

Created:
6 years, 3 months ago by viettrungluu

Modified:
6 years, 3 months ago

Reviewers:
darin (slow to review)

CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Mojo: Add a MessageInTransit::Swap() method and remove the "PassContents" ctor. R=darin@chromium.org Committed: https://crrev.com/a31e5b9195fc264cd40d44858bd216559bc337bf Cr-Commit-Position: refs/heads/master@{#295730}

Patch Set 1 #

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+9 lines, -15 lines)			Patch
M	mojo/system/message_in_transit_queue.h	View	2 chunks	+3 lines, -6 lines	0 comments	Download
M	mojo/system/message_in_transit_queue.cc	View	2 chunks	+4 lines, -5 lines	0 comments	Download
M	mojo/system/proxy_message_pipe_endpoint.cc	View	1 chunk	+2 lines, -4 lines	0 comments	Download

Messages

Total messages: 6 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/585633004/1

6 years, 3 months ago (2014-09-19 17:21:08 UTC) #4

commit-bot: I haz the power

Committed patchset #1 (id:1) as 01085acecae87f986a74b0c4c77ec397fc3e0c2b

6 years, 3 months ago (2014-09-19 17:48:31 UTC) #5

commit-bot: I haz the power

6 years, 3 months ago (2014-09-19 17:49:03 UTC) #6

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/a31e5b9195fc264cd40d44858bd216559bc337bf
Cr-Commit-Position: refs/heads/master@{#295730}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages