Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Side by Side Diff: mojo/system/message_in_transit_queue.h

Issue 585633004: Mojo: Add a MessageInTransit::Swap() method and remove the "PassContents" ctor. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | mojo/system/message_in_transit_queue.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef MOJO_SYSTEM_MESSAGE_QUEUE_H_ 5 #ifndef MOJO_SYSTEM_MESSAGE_QUEUE_H_
6 #define MOJO_SYSTEM_MESSAGE_QUEUE_H_ 6 #define MOJO_SYSTEM_MESSAGE_QUEUE_H_
7 7
8 #include <deque> 8 #include <deque>
9 9
10 #include "base/macros.h" 10 #include "base/macros.h"
11 #include "base/memory/scoped_ptr.h" 11 #include "base/memory/scoped_ptr.h"
12 #include "mojo/system/message_in_transit.h" 12 #include "mojo/system/message_in_transit.h"
13 #include "mojo/system/system_impl_export.h" 13 #include "mojo/system/system_impl_export.h"
14 14
15 namespace mojo { 15 namespace mojo {
16 namespace system { 16 namespace system {
17 17
18 // A simple queue for |MessageInTransit|s (that owns its messages). 18 // A simple queue for |MessageInTransit|s (that owns its messages).
19 // This class is not thread-safe. 19 // This class is not thread-safe.
20 // TODO(vtl): Write tests. 20 // TODO(vtl): Write tests.
21 class MOJO_SYSTEM_IMPL_EXPORT MessageInTransitQueue { 21 class MOJO_SYSTEM_IMPL_EXPORT MessageInTransitQueue {
22 public: 22 public:
23 MessageInTransitQueue(); 23 MessageInTransitQueue();
24
25 struct PassContents {};
26 // Constructor that takes over the contents of another
27 // |MessageInTransitQueue|, leaving it empty.
28 MessageInTransitQueue(PassContents, MessageInTransitQueue* other);
29
30 ~MessageInTransitQueue(); 24 ~MessageInTransitQueue();
31 25
32 bool IsEmpty() const { return queue_.empty(); } 26 bool IsEmpty() const { return queue_.empty(); }
33 27
34 void AddMessage(scoped_ptr<MessageInTransit> message) { 28 void AddMessage(scoped_ptr<MessageInTransit> message) {
35 queue_.push_back(message.release()); 29 queue_.push_back(message.release());
36 } 30 }
37 31
38 scoped_ptr<MessageInTransit> GetMessage() { 32 scoped_ptr<MessageInTransit> GetMessage() {
39 MessageInTransit* rv = queue_.front(); 33 MessageInTransit* rv = queue_.front();
40 queue_.pop_front(); 34 queue_.pop_front();
41 return make_scoped_ptr(rv); 35 return make_scoped_ptr(rv);
42 } 36 }
43 37
44 MessageInTransit* PeekMessage() { return queue_.front(); } 38 MessageInTransit* PeekMessage() { return queue_.front(); }
45 39
46 void DiscardMessage() { 40 void DiscardMessage() {
47 delete queue_.front(); 41 delete queue_.front();
48 queue_.pop_front(); 42 queue_.pop_front();
49 } 43 }
50 44
51 void Clear(); 45 void Clear();
52 46
47 // Efficiently swaps contents with |*other|.
48 void Swap(MessageInTransitQueue* other);
49
53 private: 50 private:
54 // TODO(vtl): When C++11 is available, switch this to a deque of 51 // TODO(vtl): When C++11 is available, switch this to a deque of
55 // |scoped_ptr|/|unique_ptr|s. 52 // |scoped_ptr|/|unique_ptr|s.
56 std::deque<MessageInTransit*> queue_; 53 std::deque<MessageInTransit*> queue_;
57 54
58 DISALLOW_COPY_AND_ASSIGN(MessageInTransitQueue); 55 DISALLOW_COPY_AND_ASSIGN(MessageInTransitQueue);
59 }; 56 };
60 57
61 } // namespace system 58 } // namespace system
62 } // namespace mojo 59 } // namespace mojo
63 60
64 #endif // MOJO_SYSTEM_MESSAGE_QUEUE_H_ 61 #endif // MOJO_SYSTEM_MESSAGE_QUEUE_H_
OLDNEW
« no previous file with comments | « no previous file | mojo/system/message_in_transit_queue.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698