Don't swallow "aapt crunch" build errors.

Don't swallow "aapt crunch" build errors.

aapt crunch always has a return code of 0, even when it finds an invalid
9-patch and can't process it. Since we can't trust the return code, we
fail when aapt outputs anything to stderr.

BUG=314885
R=cjhopman@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=234972

[newt (away), 2013-11-05 00:18:24]

PTAL

[cjhopman, 2013-11-05 01:10:44]

lgtm

https://codereview.chromium.org/58563004/diff/1/build/android/gyp/util/build_...
File build/android/gyp/util/build_utils.py (right):

https://codereview.chromium.org/58563004/diff/1/build/android/gyp/util/build_...
build/android/gyp/util/build_utils.py:123: return stdout + stderr
This might screw up the log quietening in ant.py. If it does, we'll probably
need to return these without concatenation and handle it there.

[newt (away), 2013-11-05 15:28:41]

https://codereview.chromium.org/58563004/diff/1/build/android/gyp/util/build_...
File build/android/gyp/util/build_utils.py (right):

https://codereview.chromium.org/58563004/diff/1/build/android/gyp/util/build_...
build/android/gyp/util/build_utils.py:123: return stdout + stderr
On 2013/11/05 01:10:45, cjhopman wrote:
> This might screw up the log quietening in ant.py. If it does, we'll probably
> need to return these without concatenation and handle it there.

Yes, we might need to readjust, though I think the only thing this changes is
the interleaving of stdout and stderr. Previously, we redirected stderr to
stdout, so "return stdout" actually returned both streams, but interleaved
instead of concatenated. Still, it's possible some error messages will be
confusing with this new order. Let's find out :)

[newt (away), 2013-11-05 15:30:26]

The trybots just failed to compile ("malformed 9-patch") which means this patch
is working!

First time that's ever been the case :)

[commit-bot: I haz the power, 2013-11-13 01:01:19]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/newt@chromium.org/58563004/1

[commit-bot: I haz the power, 2013-11-13 01:40:28]

Retried try job too often on chromium_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

[newt (away), 2013-11-14 00:13:49]

Committed patchset #1 manually as r234972 (presubmit successful).