build/android/gyp/process_resources.py - Issue 58563004: Don't swallow "aapt crunch" build errors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/gyp/process_resources.py

Issue 58563004: Don't swallow "aapt crunch" build errors. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/android/gyp/process_resources.py

diff --git a/build/android/gyp/process_resources.py b/build/android/gyp/process_resources.py

index d10b66647607812cc63782a71876c0127be8af34..cd7fbabbfe03edc264dcd5f2e903a7c5960066bc 100755

--- a/build/android/gyp/process_resources.py

+++ b/build/android/gyp/process_resources.py

@@ -113,7 +113,7 @@ def main():

'crunch',

'-S', options.crunch_input_dir,

'-C', options.crunch_output_dir]

- build_utils.CheckCallDie(aapt_cmd, suppress_output=True)

+ build_utils.CheckCallDie(aapt_cmd, suppress_output=True, fail_if_stderr=True)

MoveImagesToNonMdpiFolders(options.crunch_output_dir)