Issue 5856002: Add support for compacting the write buffer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5856002: Add support for compacting the write buffer. (Closed)

Created:
10 years ago by Erik Corry

Modified:
9 years, 7 months ago

Reviewers:
Vyacheslav Egorov (Chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/experimental/gc/

Visibility:
Public.

Description

Add support for compacting the write buffer. Committed: http://code.google.com/p/v8/source/detail?r=6056

Patch Set 1 #

Total comments: 1

Created: 10 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+66 lines, -3 lines)			Patch
M	src/counters.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/v8-counters.h	View	2 chunks	+6 lines, -1 line	0 comments	Download
M	src/write-buffer.h	View	1 chunk	+5 lines, -1 line	0 comments	Download
M	src/write-buffer.cc	View	3 chunks	+52 lines, -1 line	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Vyacheslav Egorov (Chromium)

10 years ago (2010-12-16 10:36:39 UTC) #2

LGTM

http://codereview.chromium.org/5856002/diff/1/src/write-buffer.cc
File src/write-buffer.cc (right):

http://codereview.chromium.org/5856002/diff/1/src/write-buffer.cc#newcode88
src/write-buffer.cc:88: for (Address* current = start_; current < stop;
current++) {
More comments about design please. 

Compaction does not remove all duplicates?

Expand Messages | Collapse Messages