Mac: Give app_shim code a nicer home

Mac: Give app_shim code a nicer home

App Shims are small .app bundles for Mac, which run in their own
process to provide packaged apps with an OSX Dock icon, using IPC to
communicate with the browser process.

Most of the app_shim code currently lives in src/apps/app_shim, but app
shims are very much a browser feature, so it doesn't belong there. It's
causing DEPS problems for athena efforts.

This CL moves most of apps/app_shim to chrome/browser/apps/app_shim
(c/b/apps didn't exist until a few months after src/apps/app_shim).

The shim itself (i.e. chrome_main_app_mode_mac.mm) doesn't run in the
browser process - it has its own, shim process. Those parts are moved to
a new folder: src/chrome/app_shim, consolidating files currently spread
across src/apps/app_shim and src/chrome/app.

app_shim_launch.h and app_shim_messages.h are used in both the shim
process and the browser process. They're moved to chrome/common/mac.

Summary of changes:
  {apps => chrome/browser/apps}/app_shim/*
except
  {apps => chrome}/app_shim/chrome_main_app_mode_mac.mm
  {apps/app_shim => chrome/common/mac}/app_shim_launch.h
  {apps/app_shim => chrome/common/mac}/app_shim_messages.h
  app_shim.gypi renamed to browser_app_shim.gypi
  chrome/app_shim/app_shim.gypi added
and
  chrome/{app => app_shim}/app_mode-Info.plist
  chrome/{app => app_shim}/app_mode_loader_mac.mm

- apps/app_shim/DEPS now just generated_resources.h
- 'app_mode_app' target moved from chrome.gyp to app_shim.gypi

BUG=266705
Committed: https://crrev.com/63829f711468110d04c7464acf92c3e7ab3c13d7
Cr-Commit-Position: refs/heads/master@{#296576}

[tapted, 2014-09-22 07:30:44]

tapted@chromium.org changed reviewers:
+ jackhou@chromium.org

[tapted, 2014-09-22 07:57:19]

Hi Jack - please take a look

[jackhou1, 2014-09-23 03:11:39]

On 2014/09/22 07:57:19, tapted wrote:
> Hi Jack - please take a look

lgtm

Should we also be per-file OWNERS for chrome/common/mac/app_shim*?

[tapted, 2014-09-23 06:47:16]

On 2014/09/23 03:11:39, jackhou1 wrote:
> On 2014/09/22 07:57:19, tapted wrote:
> > Hi Jack - please take a look
> 
> lgtm
> 
> Should we also be per-file OWNERS for chrome/common/mac/app_shim*?

I had a look.. maybe in a follow-up. Adding per-owners for app_shim_* might be
misleading, since app_shim_messages.h still needs an IPC owner, and
app_shim_launch.h is pretty boring. Probably we should rename the app_mode_*
files to app_shim_* at the same time, and/or move all the app_shim files to a
different subfolder under chrome/common/[mac/]

[tapted, 2014-09-23 07:02:20]

tapted@chromium.org changed reviewers:
+ rsesek@chromium.org, sky@chromium.org

[tapted, 2014-09-23 07:02:21]

+sky,rsesek,palmer: 

 sky: Please review changes in src/chrome
 rsesek: Please review changes in src/chrome/common/mac and (general mac
stuff/gypfiles)
 palmer: Please review IPC for src/chrome/common/mac/app_shim_messages.h (just a
#include change, but the file is also moving)

important notes:
 ** adding new folder src/chrome/app_shim
   -- for the app_shim process parts currently spread across src/apps/app_shim
and src/chrome/app
 ** app_shim stuff that run in the browser process is moving from
src/apps/app_shim to src/chrome/browser/apps/app_shim
 ** chrome/chrome.gyp getting some structural changes

more details in CL description.

Thanks!

[tapted, 2014-09-23 07:04:15]

tapted@chromium.org changed reviewers:
+ palmer@chromium.org

[tapted, 2014-09-23 07:04:16]

+palmer (actually) for IPC (#include change, but also a file move. Last file in
the list: chrome/common/mac/app_shim_messages.h)

[palmer, 2014-09-23 20:40:45]

Rubberstamp LGTM

[sky, 2014-09-23 23:12:11]

sky@chromium.org changed reviewers:
+ avi@chromium.org
- palmer@chromium.org

[sky, 2014-09-23 23:12:12]

LGTM

[Robert Sesek, 2014-09-24 14:58:48]

LGTM

[tapted, 2014-09-24 23:17:42]

The CQ bit was checked by tapted@chromium.org

[commit-bot: I haz the power, 2014-09-24 23:18:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/585123004/20001

[commit-bot: I haz the power, 2014-09-24 23:51:01]

Committed patchset #2 (id:20001) as 568d74e454d168de42e72a45769afde0217c76ef

[commit-bot: I haz the power, 2014-09-24 23:51:42]

Patchset 2 (id:??) landed as
https://crrev.com/63829f711468110d04c7464acf92c3e7ab3c13d7
Cr-Commit-Position: refs/heads/master@{#296576}