Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Side by Side Diff: chrome/app_shim/app_mode_loader_mac.mm

Issue 585123004: Mac: Give app_shim code a nicer home (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: various cleanups Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/app_shim/app_mode-Info.plist ('k') | chrome/app_shim/app_shim.gypi » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // On Mac, shortcuts can't have command-line arguments. Instead, produce small 5 // On Mac, shortcuts can't have command-line arguments. Instead, produce small
6 // app bundles which locate the Chromium framework and load it, passing the 6 // app bundles which locate the Chromium framework and load it, passing the
7 // appropriate data. This is the code for such an app bundle. It should be kept 7 // appropriate data. This is the code for such an app bundle. It should be kept
8 // minimal and do as little work as possible (with as much work done on 8 // minimal and do as little work as possible (with as much work done on
9 // framework side as possible). 9 // framework side as possible).
10 10
(...skipping 186 matching lines...) Expand 10 before | Expand all | Expand 10 after
197 // Hard coded info parameters. 197 // Hard coded info parameters.
198 info.major_version = app_mode::kCurrentChromeAppModeInfoMajorVersion; 198 info.major_version = app_mode::kCurrentChromeAppModeInfoMajorVersion;
199 info.minor_version = app_mode::kCurrentChromeAppModeInfoMinorVersion; 199 info.minor_version = app_mode::kCurrentChromeAppModeInfoMinorVersion;
200 info.argc = argc; 200 info.argc = argc;
201 info.argv = argv; 201 info.argv = argv;
202 202
203 // Exit instead of returning to avoid the the removal of |main()| from stack 203 // Exit instead of returning to avoid the the removal of |main()| from stack
204 // backtraces under tail call optimization. 204 // backtraces under tail call optimization.
205 exit(LoadFrameworkAndStart(&info)); 205 exit(LoadFrameworkAndStart(&info));
206 } 206 }
OLDNEW
« no previous file with comments | « chrome/app_shim/app_mode-Info.plist ('k') | chrome/app_shim/app_shim.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698