Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 584883003: Remove implicit conversions from scoped_refptr to T* in base/ (Closed)

Created:
6 years, 3 months ago by dcheng
Modified:
6 years, 3 months ago
CC:
chromium-reviews, erikwright+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove implicit conversions from scoped_refptr to T* in base/ This patch was generated by running the rewrite_scoped_refptr clang tool on a Mac build. BUG=110610 Committed: https://crrev.com/c041fef8226db56fcec101567c9eef0f9ce49ef5 Cr-Commit-Position: refs/heads/master@{#295855}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M base/files/file_path_watcher_mac.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
dcheng
6 years, 3 months ago (2014-09-19 17:02:23 UTC) #2
rvargas (doing something else)
lgtm
6 years, 3 months ago (2014-09-20 00:49:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/584883003/1
6 years, 3 months ago (2014-09-20 00:56:50 UTC) #5
commit-bot: I haz the power
Exceeded time limit waiting for builds to trigger.
6 years, 3 months ago (2014-09-20 02:58:52 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/584883003/1
6 years, 3 months ago (2014-09-20 03:30:45 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as 8230d09188493d61c9232c29ccbbd5cd39e90701
6 years, 3 months ago (2014-09-20 03:31:31 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1) as ea05d085b8afeff420a9cb53f5c19fb8088dd251
6 years, 3 months ago (2014-09-20 03:31:40 UTC) #11
commit-bot: I haz the power
6 years, 3 months ago (2014-09-20 03:32:06 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c041fef8226db56fcec101567c9eef0f9ce49ef5
Cr-Commit-Position: refs/heads/master@{#295855}

Powered by Google App Engine
This is Rietveld 408576698