base/files/file_path_watcher_mac.cc - Issue 584883003: Remove implicit conversions from scoped_refptr to T* in base/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/files/file_path_watcher_mac.cc

Issue 584883003: Remove implicit conversions from scoped_refptr to T* in base/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/files/file_path_watcher_mac.cc

diff --git a/base/files/file_path_watcher_mac.cc b/base/files/file_path_watcher_mac.cc

index 54ca46d12bbdf9e9c33692555e3bc0e1040102be..b21ba1d65bba12538016fe6c5d35fa8db6131335 100644

--- a/base/files/file_path_watcher_mac.cc

+++ b/base/files/file_path_watcher_mac.cc

@@ -34,13 +34,13 @@ class FilePathWatcherImpl : public FilePathWatcher::PlatformDelegate {

}

virtual void Cancel() OVERRIDE {

- if (impl_)

+ if (impl_.get())

impl_->Cancel();

set_cancelled();

}

virtual void CancelOnMessageLoopThread() OVERRIDE {

- if (impl_)

+ if (impl_.get())

impl_->Cancel();

set_cancelled();

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »