Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Issue 584823002: Move apps/app_shim to chrome/browser/apps (Closed)

Created:
6 years, 3 months ago by hashimoto
Modified:
6 years, 3 months ago
Reviewers:
tapted
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina, extensions-reviews_chromium.org, chromium-apps-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Move apps/app_shim to chrome/browser/apps apps/app_shim/DEPS is omitted. BUG=266705

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -3966 lines) Patch
D apps/app_shim/DEPS View 1 chunk +0 lines, -19 lines 0 comments Download
D apps/app_shim/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
D apps/app_shim/app_shim.gypi View 1 chunk +0 lines, -36 lines 0 comments Download
D apps/app_shim/app_shim_handler_mac.h View 1 chunk +0 lines, -96 lines 0 comments Download
D apps/app_shim/app_shim_handler_mac.cc View 1 chunk +0 lines, -156 lines 0 comments Download
D apps/app_shim/app_shim_host_mac.h View 1 chunk +0 lines, -86 lines 0 comments Download
D apps/app_shim/app_shim_host_mac.cc View 1 chunk +0 lines, -130 lines 0 comments Download
D apps/app_shim/app_shim_host_mac_unittest.cc View 1 chunk +0 lines, -175 lines 0 comments Download
D apps/app_shim/app_shim_host_manager_browsertest_mac.mm View 1 chunk +0 lines, -287 lines 0 comments Download
D apps/app_shim/app_shim_host_manager_mac.h View 1 chunk +0 lines, -73 lines 0 comments Download
D apps/app_shim/app_shim_host_manager_mac.mm View 1 chunk +0 lines, -168 lines 0 comments Download
D apps/app_shim/app_shim_interactive_uitest_mac.mm View 1 chunk +0 lines, -399 lines 0 comments Download
D apps/app_shim/app_shim_launch.h View 1 chunk +0 lines, -57 lines 0 comments Download
D apps/app_shim/app_shim_messages.h View 1 chunk +0 lines, -71 lines 0 comments Download
D apps/app_shim/app_shim_quit_interactive_uitest_mac.mm View 1 chunk +0 lines, -132 lines 0 comments Download
D apps/app_shim/chrome_main_app_mode_mac.mm View 1 chunk +0 lines, -693 lines 0 comments Download
D apps/app_shim/extension_app_shim_handler_mac.h View 1 chunk +0 lines, -159 lines 0 comments Download
D apps/app_shim/extension_app_shim_handler_mac.cc View 1 chunk +0 lines, -557 lines 0 comments Download
D apps/app_shim/extension_app_shim_handler_mac_unittest.cc View 1 chunk +0 lines, -396 lines 0 comments Download
D apps/app_shim/test/app_shim_host_manager_test_api_mac.h View 1 chunk +0 lines, -38 lines 0 comments Download
D apps/app_shim/test/app_shim_host_manager_test_api_mac.cc View 1 chunk +0 lines, -26 lines 0 comments Download
D apps/app_shim/unix_domain_socket_acceptor.h View 1 chunk +0 lines, -57 lines 0 comments Download
D apps/app_shim/unix_domain_socket_acceptor.cc View 1 chunk +0 lines, -90 lines 0 comments Download
M chrome/browser/app_controller_mac.mm View 2 chunks +1 line, -1 line 0 comments Download
A + chrome/browser/apps/app_shim/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/apps/app_shim/app_shim.gypi View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/apps/app_shim/app_shim_handler_mac.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/apps/app_shim/app_shim_handler_mac.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/apps/app_shim/app_shim_host_mac.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/apps/app_shim/app_shim_host_mac.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A + chrome/browser/apps/app_shim/app_shim_host_mac_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + chrome/browser/apps/app_shim/app_shim_host_manager_browsertest_mac.mm View 1 chunk +3 lines, -3 lines 0 comments Download
A + chrome/browser/apps/app_shim/app_shim_host_manager_mac.h View 2 chunks +5 lines, -5 lines 0 comments Download
A + chrome/browser/apps/app_shim/app_shim_host_manager_mac.mm View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/apps/app_shim/app_shim_interactive_uitest_mac.mm View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/apps/app_shim/app_shim_launch.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/apps/app_shim/app_shim_messages.h View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/apps/app_shim/app_shim_quit_interactive_uitest_mac.mm View 1 chunk +2 lines, -2 lines 0 comments Download
A + chrome/browser/apps/app_shim/chrome_main_app_mode_mac.mm View 2 chunks +1 line, -1 line 0 comments Download
A + chrome/browser/apps/app_shim/extension_app_shim_handler_mac.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/apps/app_shim/extension_app_shim_handler_mac.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A + chrome/browser/apps/app_shim/extension_app_shim_handler_mac_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + chrome/browser/apps/app_shim/test/app_shim_host_manager_test_api_mac.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/apps/app_shim/test/app_shim_host_manager_test_api_mac.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + chrome/browser/apps/app_shim/unix_domain_socket_acceptor.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/apps/app_shim/unix_domain_socket_acceptor.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/browser_process_platform_part_mac.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chrome_browser_main_mac.mm View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/app_list/app_list_service_mac.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/app_list/app_list_service_mac_interactive_uitest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/apps/app_shim_menu_controller_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/apps/native_app_window_cocoa.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome.gyp View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_tests.gypi View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/common/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/common_message_generator.h View 1 chunk +1 line, -1 line 1 comment Download

Messages

Total messages: 5 (1 generated)
hashimoto
6 years, 3 months ago (2014-09-19 08:35:24 UTC) #2
tapted
Wow you are quick! Thanks for doing this - there are some additional code/layout things ...
6 years, 3 months ago (2014-09-19 12:10:28 UTC) #3
hashimoto
tapted@ kindly took the responsibility for doing this. Thanks! Closing this issue.
6 years, 3 months ago (2014-09-22 03:51:12 UTC) #4
tapted
6 years, 3 months ago (2014-09-22 08:03:12 UTC) #5
Message was sent while issue was closed.
On 2014/09/22 03:51:12, hashimoto wrote:
> tapted@ kindly took the responsibility for doing this.
> Thanks!
> 
> Closing this issue.

Thanks for the push we needed to get started on this!. New CL out for review at
https://codereview.chromium.org/585123004/

Powered by Google App Engine
This is Rietveld 408576698