chrome/common/common_message_generator.h - Issue 584823002: Move apps/app_shim to chrome/browser/apps

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/common/common_message_generator.h

Issue 584823002: Move apps/app_shim to chrome/browser/apps (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/common/DEPS ('k') | no next file » | no next file with comments »

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 // Multiply-included file, hence no include guard.	5 // Multiply-included file, hence no include guard.

6	6

7 #include "apps/app_shim/app_shim_messages.h"	7 #include "chrome/browser/apps/app_shim/app_shim_messages.h"
	tapted 2014/09/19 12:10:28 hm - this feels out of place here. This header (an hm - this feels out of place here. This header (and app_shim_launch.h) belong in chrome/common. Then most of the other files belong in chrome/browser/apps/app_shim (as you've done). But chrome_main_app_mode_mac.mm doesn't run in the browser process so, I think it belongs in (a new folder) src/chrome/app_shim. I think that's all - later, there's also stuff in src/chrome/app (e.g. app_mode_loader_mac.mm), which should move to src/chrome/app_shim, but you can leave that for us.
8 #include "chrome/common/benchmarking_messages.h"	8 #include "chrome/common/benchmarking_messages.h"

9 #include "chrome/common/cast_messages.h"	9 #include "chrome/common/cast_messages.h"

10 #include "chrome/common/chrome_utility_messages.h"	10 #include "chrome/common/chrome_utility_messages.h"

11 // TODO(thestig) move this inside defined(ENABLE_EXTENSIONS)	11 // TODO(thestig) move this inside defined(ENABLE_EXTENSIONS)

12 #include "chrome/common/extensions/chrome_extension_messages.h"	12 #include "chrome/common/extensions/chrome_extension_messages.h"

13 #include "chrome/common/prefetch_messages.h"	13 #include "chrome/common/prefetch_messages.h"

14 #include "chrome/common/prerender_messages.h"	14 #include "chrome/common/prerender_messages.h"

15 #include "chrome/common/render_messages.h"	15 #include "chrome/common/render_messages.h"

16 #include "chrome/common/tts_messages.h"	16 #include "chrome/common/tts_messages.h"

17	17

(...skipping 18 matching lines...) Expand all Loading...
36 #include "chrome/common/spellcheck_messages.h"	36 #include "chrome/common/spellcheck_messages.h"

37 #endif	37 #endif

38	38

39 #if defined(ENABLE_WEBRTC)	39 #if defined(ENABLE_WEBRTC)

40 #include "chrome/common/media/webrtc_logging_messages.h"	40 #include "chrome/common/media/webrtc_logging_messages.h"

41 #endif	41 #endif

42	42

43 #if defined(FULL_SAFE_BROWSING) \|\| defined(MOBILE_SAFE_BROWSING)	43 #if defined(FULL_SAFE_BROWSING) \|\| defined(MOBILE_SAFE_BROWSING)

44 #include "chrome/common/safe_browsing/safebrowsing_messages.h"	44 #include "chrome/common/safe_browsing/safebrowsing_messages.h"

45 #endif	45 #endif

OLD	NEW