Browser Plugin: Remove dependency on NPAPI

Browser Plugin: Remove dependency on NPAPI

The CL moves the final attribute on BrowserPlugin 'allowtransparency' out to the extensions module! No new content APIs had to be introduced! Transparency can be enabled from RenderWidgetHostView::SetBackgroundOpaque in the content embedder.

This means that BrowserPlugin no longer depends on NPAPI and so this patch removes a lot of unnecessary code.

TBR=asvitkine@chromium.org for histograms.xml, extension_function_histogram_value.h

TBR=asvitkine@chromium.org for histograms.xml, extension
BUG=330264
Committed: https://crrev.com/516005f409bc6d2221c4be32fe1c0920975cf1ae
Cr-Commit-Position: refs/heads/master@{#295879}

[Fady Samuel, 2014-09-19 15:32:15]

fsamuel@chromium.org changed reviewers:
+ lazyboy@chromium.org

[Fady Samuel, 2014-09-19 17:29:20]

PTAL fixed the segfault. Needed to wait for initial navigation to access the
RenderWidgetHostView.

[lazyboy, 2014-09-19 17:57:02]

https://chromiumcodereview.appspot.com/584713002/diff/60001/extensions/render...
File extensions/renderer/resources/web_view.js (right):

https://chromiumcodereview.appspot.com/584713002/diff/60001/extensions/render...
extensions/renderer/resources/web_view.js:384: // <webview> src does not quite
behave the same as BrowserPlugin src, and so
BrowserPlugin doesn't have a .src anymore, so this comment is stale.

https://chromiumcodereview.appspot.com/584713002/diff/80001/extensions/render...
File extensions/renderer/resources/web_view.js (right):

https://chromiumcodereview.appspot.com/584713002/diff/80001/extensions/render...
extensions/renderer/resources/web_view.js:472: this.allowtransparency = newValue
== 'true';
this.allowtransparency = newValue != '';
Because we merely look at the existence of allowtransparency attribute to set
transparency.
Maybe add a small test for this too.

[Fady Samuel, 2014-09-19 19:53:59]

PTAL

https://chromiumcodereview.appspot.com/584713002/diff/60001/extensions/render...
File extensions/renderer/resources/web_view.js (right):

https://chromiumcodereview.appspot.com/584713002/diff/60001/extensions/render...
extensions/renderer/resources/web_view.js:384: // <webview> src does not quite
behave the same as BrowserPlugin src, and so
On 2014/09/19 17:57:01, lazyboy wrote:
> BrowserPlugin doesn't have a .src anymore, so this comment is stale.

The comment is unnecessary. Removed.

https://chromiumcodereview.appspot.com/584713002/diff/80001/extensions/render...
File extensions/renderer/resources/web_view.js (right):

https://chromiumcodereview.appspot.com/584713002/diff/80001/extensions/render...
extensions/renderer/resources/web_view.js:472: this.allowtransparency = newValue
== 'true';
On 2014/09/19 17:57:02, lazyboy wrote:
> this.allowtransparency = newValue != '';
> Because we merely look at the existence of allowtransparency attribute to set
> transparency.
> Maybe add a small test for this too.

Done.

[lazyboy, 2014-09-19 20:07:12]

lgtm

[Fady Samuel, 2014-09-19 20:13:09]

fsamuel@chromium.org changed reviewers:
+ creis@chromium.org, kenrb@chromium.org, rockot@chromium.org

[Fady Samuel, 2014-09-19 20:13:10]

creis@ for rwhvguest + content_renderer.gypi
rockot@ for non-guestview extensions stuff
kenrb@ for *_messages.h

[Charlie Reis, 2014-09-19 20:31:51]

LGTM

[kenrb, 2014-09-19 21:26:19]

ipc lgtm

[Fady Samuel, 2014-09-19 21:29:54]

The CQ bit was checked by fsamuel@chromium.org

[Fady Samuel, 2014-09-19 21:30:01]

The CQ bit was unchecked by fsamuel@chromium.org

[Ken Rockot(use gerrit already), 2014-09-19 22:36:52]

On 2014/09/19 21:26:19, kenrb wrote:
> ipc lgtm

lgtm

[Fady Samuel, 2014-09-19 22:56:30]

The CQ bit was checked by fsamuel@chromium.org

[commit-bot: I haz the power, 2014-09-19 22:57:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/584713002/100001

[commit-bot: I haz the power, 2014-09-19 22:57:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/584713002/100001

[commit-bot: I haz the power, 2014-09-19 23:23:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-19 23:23:19]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[commit-bot: I haz the power, 2014-09-19 23:23:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-19 23:23:59]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Fady Samuel, 2014-09-19 23:53:44]

fsamuel@chromium.org changed reviewers:
+ asvitkine@chromium.org

[Fady Samuel, 2014-09-19 23:53:45]

+asvitkine@ for extension_function_histogram_value

[Fady Samuel, 2014-09-20 15:59:50]

The CQ bit was checked by fsamuel@chromium.org

[commit-bot: I haz the power, 2014-09-20 16:00:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/584713002/140001

[commit-bot: I haz the power, 2014-09-20 16:58:05]

Committed patchset #8 (id:140001) as de4b889e2716b43d1f630eb6613f6e7272682923

[commit-bot: I haz the power, 2014-09-20 16:58:42]

Patchset 8 (id:??) landed as
https://crrev.com/516005f409bc6d2221c4be32fe1c0920975cf1ae
Cr-Commit-Position: refs/heads/master@{#295879}