content/browser/browser_plugin/browser_plugin_guest.h - Issue 584713002: Browser Plugin: Remove dependency on NPAPI

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/browser_plugin/browser_plugin_guest.h

Issue 584713002: Browser Plugin: Remove dependency on NPAPI (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@move_content_window

Patch Set: Updated histograms.xml Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/test/data/extensions/platform_apps/web_view/shim/main.js ('k') | content/browser/browser_plugin/browser_plugin_guest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/browser_plugin/browser_plugin_guest.h

diff --git a/content/browser/browser_plugin/browser_plugin_guest.h b/content/browser/browser_plugin/browser_plugin_guest.h

index 13aed3388c14f6cdb680851b9080bb613f11f675..cecca6de166bdef20bd3fb02d0282830af6e9146 100644

--- a/content/browser/browser_plugin/browser_plugin_guest.h

+++ b/content/browser/browser_plugin/browser_plugin_guest.h

@@ -203,6 +203,8 @@ class CONTENT_EXPORT BrowserPluginGuest : public WebContentsObserver {

int host_routing_id,

scoped_ptr<cc::CompositorFrame> frame);

+ void SetContentsOpaque(bool opaque);

private:

class EmbedderWebContentsObserver;

@@ -263,7 +265,6 @@ class CONTENT_EXPORT BrowserPluginGuest : public WebContentsObserver {

void OnSetEditCommandsForNextKeyEvent(

int instance_id,

const std::vector<EditCommand>& edit_commands);

- void OnSetContentsOpaque(int instance_id, bool opaque);

// The guest WebContents is visible if both its embedder is visible and

// the browser plugin element is visible. If either one is not then the

// WebContents is marked as hidden. A hidden WebContents will consume

@@ -336,7 +337,6 @@ class CONTENT_EXPORT BrowserPluginGuest : public WebContentsObserver {

bool mouse_locked_;

bool pending_lock_request_;

bool guest_visible_;

- bool guest_opaque_;

bool embedder_visible_;

// Each copy-request is identified by a unique number. The unique number is