Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(358)

Unified Diff: ui/gl/BUILD.gn

Issue 584683002: Improve GN header checker, make //ui pass. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: merge Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/gfx/BUILD.gn ('k') | ui/keyboard/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/gl/BUILD.gn
diff --git a/ui/gl/BUILD.gn b/ui/gl/BUILD.gn
index 341e695df95bf1f2f5aa7cd4185d514e661e9d13..2bdd76d1498bf197c4bbafba28ce6a7d2cd5a878 100644
--- a/ui/gl/BUILD.gn
+++ b/ui/gl/BUILD.gn
@@ -118,19 +118,18 @@ component("gl") {
deps = [
":generate_gl_bindings",
- "//base",
"//base/third_party/dynamic_annotations",
"//gpu/command_buffer/common",
- "//third_party/mesa:mesa_headers",
"//skia",
+ ]
+ public_deps = [
+ "//base",
+ "//third_party/mesa:mesa_headers",
"//ui/events/platform",
"//ui/gfx",
"//ui/gfx/geometry",
]
- # TODO(GYP) hook up once this is converted.
- forward_dependent_configs_from = [ "//third_party/mesa:mesa_headers" ]
-
if (is_win || is_android || is_linux) {
sources += [
"egl_util.cc",
@@ -342,7 +341,6 @@ if (is_android) {
generate_jni("gl_jni_headers") {
deps = [ ":surface_jni_headers" ]
- forward_dependent_configs_from = [ ":surface_jni_headers" ]
sources = [
"../android/java/src/org/chromium/ui/gl/SurfaceTextureListener.java",
"../android/java/src/org/chromium/ui/gl/SurfaceTexturePlatformWrapper.java",
« no previous file with comments | « ui/gfx/BUILD.gn ('k') | ui/keyboard/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698