Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1231)

Unified Diff: ui/gfx/BUILD.gn

Issue 584683002: Improve GN header checker, make //ui pass. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: merge Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/events/platform/x11/BUILD.gn ('k') | ui/gl/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/gfx/BUILD.gn
diff --git a/ui/gfx/BUILD.gn b/ui/gfx/BUILD.gn
index 4dd98e065891f5d166889826acd4a701c24e7309..d8c71f5d43fe4c379d48239cb6a2164bf766d8a9 100644
--- a/ui/gfx/BUILD.gn
+++ b/ui/gfx/BUILD.gn
@@ -221,19 +221,20 @@ component("gfx") {
deps = [
":gfx_export",
- "//base",
"//base:i18n",
"//base:base_static",
"//base/third_party/dynamic_annotations",
"//skia",
"//third_party/harfbuzz-ng",
- "//third_party/icu:icui18n",
- "//third_party/icu:icuuc",
"//third_party/libpng",
"//third_party/zlib",
"//ui/gfx/geometry",
]
- forward_dependent_configs_from = [ "//skia" ]
+ public_deps = [
+ "//base",
+ "//skia",
+ "//third_party/icu",
+ ]
# Text rendering conditions (complicated so separated out).
if (is_android || is_ios) {
@@ -378,8 +379,11 @@ source_set("test_support") {
"test/ui_cocoa_test_helper.mm",
]
- deps = [
+ public_deps = [
":gfx",
+ ]
+
+ deps = [
"//base",
"//base/test:test_support",
"//skia",
@@ -464,6 +468,7 @@ test("gfx_unittests") {
"//skia",
"//third_party/icu:icuuc",
"//third_party/libpng",
+ "//third_party/zlib",
"//testing/gtest",
"//ui/base",
"//ui/gfx/geometry",
« no previous file with comments | « ui/events/platform/x11/BUILD.gn ('k') | ui/gl/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698