Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2526)

Unified Diff: cc/animation/layer_animation_controller.cc

Issue 584503005: Make scroll offset type of float in cc (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: scroll delta -> vector2dF, scroll offset -> ScrollOffset Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | cc/animation/layer_animation_value_provider.h » ('j') | cc/blink/web_layer_impl.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/animation/layer_animation_controller.cc
diff --git a/cc/animation/layer_animation_controller.cc b/cc/animation/layer_animation_controller.cc
index 08a0ee91f1854cf4fc5020b50d8996803a9f1c01..93f2c5967155e954cae414736fc73e3017a39b13 100644
--- a/cc/animation/layer_animation_controller.cc
+++ b/cc/animation/layer_animation_controller.cc
@@ -534,7 +534,7 @@ void LayerAnimationController::PushNewAnimationsToImplThread(
// Scroll animations always start at the current scroll offset.
if (animations_[i]->target_property() == Animation::ScrollOffset) {
- gfx::Vector2dF current_scroll_offset;
+ gfx::ScrollOffset current_scroll_offset;
if (controller_impl->value_provider_) {
current_scroll_offset =
controller_impl->value_provider_->ScrollOffsetForAnimation();
@@ -544,7 +544,7 @@ void LayerAnimationController::PushNewAnimationsToImplThread(
current_scroll_offset = value_provider_->ScrollOffsetForAnimation();
}
animations_[i]->curve()->ToScrollOffsetAnimationCurve()->SetInitialValue(
- current_scroll_offset);
+ current_scroll_offset.ToVector2dF());
danakj 2014/09/25 22:01:26 ScrollOffsetAnimationCurve should be ScrollOffsets
Yufeng Shen (Slow to review) 2014/09/26 20:19:07 Done.
}
// The new animation should be set to run as soon as possible.
« no previous file with comments | « no previous file | cc/animation/layer_animation_value_provider.h » ('j') | cc/blink/web_layer_impl.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698