Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1875)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: cc/blink/web_layer_impl.h

Issue 584503005: Make scroll offset type of float in cc (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: scroll delta -> vector2dF, scroll offset -> ScrollOffset Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« cc/animation/layer_animation_controller.cc ('K') | « cc/base/math_util.cc ('k') | cc/blink/web_layer_impl.cc » ('j') | cc/layers/layer.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/blink/web_layer_impl.h
diff --git a/cc/blink/web_layer_impl.h b/cc/blink/web_layer_impl.h
index 3a8130e30b4b068fa45108b7cbf1bdc3aa123bf2..f265d516c60c0b0fc70ac7c6ca0913d924813914 100644
--- a/cc/blink/web_layer_impl.h
+++ b/cc/blink/web_layer_impl.h
@@ -14,6 +14,7 @@
#include "third_party/WebKit/public/platform/WebCString.h"
#include "third_party/WebKit/public/platform/WebColor.h"
#include "third_party/WebKit/public/platform/WebCompositorAnimation.h"
+#include "third_party/WebKit/public/platform/WebDoublePoint.h"
#include "third_party/WebKit/public/platform/WebFloatPoint.h"
#include "third_party/WebKit/public/platform/WebLayer.h"
#include "third_party/WebKit/public/platform/WebPoint.h"
@@ -102,6 +103,10 @@ class WebLayerImpl : public blink::WebLayer, public cc::LayerClient {
virtual void pauseAnimation(int animation_id, double time_offset);
virtual bool hasActiveAnimation();
virtual void setForceRenderSurface(bool force);
+ // TODO(miletus): Remove the WebPoint version once blink side starts to
+ // use the WebDoublePoint version.
+ virtual void setScrollPositionFloat(blink::WebDoublePoint position);
danakj 2014/09/25 22:01:26 const&
Yufeng Shen (Slow to review) 2014/09/26 20:19:07 Done.
+ virtual blink::WebDoublePoint scrollPositionFloat() const;
virtual void setScrollPosition(blink::WebPoint position);
virtual blink::WebPoint scrollPosition() const;
virtual void setScrollClipLayer(blink::WebLayer* clip_layer);
« cc/animation/layer_animation_controller.cc ('K') | « cc/base/math_util.cc ('k') | cc/blink/web_layer_impl.cc » ('j') | cc/layers/layer.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698