net/cert/x509_certificate_openssl.cc - Issue 584463005: Add debugging information to the SSL blocking page

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/cert/x509_certificate_openssl.cc

Issue 584463005: Add debugging information to the SSL blocking page (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added a few more checks in x509_certificate_ files Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/cert/x509_certificate_openssl.cc

diff --git a/net/cert/x509_certificate_openssl.cc b/net/cert/x509_certificate_openssl.cc

index 72d5eee063444215991fae8747d4e584835b61ec..9cb0670d51c1bc56ddf87c82c8c21ea6a744e547 100644

--- a/net/cert/x509_certificate_openssl.cc

+++ b/net/cert/x509_certificate_openssl.cc

@@ -309,7 +309,7 @@ X509_STORE* X509Certificate::cert_store() {

bool X509Certificate::GetDEREncoded(X509Certificate::OSCertHandle cert_handle,

std::string* encoded) {

base::StringPiece der;

- if (!x509_util::GetDER(cert_handle, &der))

+ if (!cert_handle || !x509_util::GetDER(cert_handle, &der))

return false;

encoded->assign(der.data(), der.length());

return true;