Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(373)

Issue 584433002: Add UI for the new harmful download warning (Closed)

Created:
6 years, 3 months ago by felt
Modified:
6 years, 2 months ago
CC:
chromium-reviews, gab
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add UI for the new harmful download warning BUG=397754 R=mattm@chromium.org Committed: https://crrev.com/7f383143f3116d8b3ce4a148ebb99e60aeb64c0e Cr-Commit-Position: refs/heads/master@{#296039}

Patch Set 1 #

Patch Set 2 : Added a few tests #

Patch Set 3 : Add histograms to histograms.xml #

Total comments: 6

Patch Set 4 : mattm's comments #

Patch Set 5 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+123 lines, -14 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_blocking_page.h View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_blocking_page.cc View 1 2 3 4 8 chunks +66 lines, -9 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc View 1 2 3 2 chunks +34 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (2 generated)
felt
Hi Matt, please review? This CL is dependent on https://codereview.chromium.org/578103002/, which I mailed separately because ...
6 years, 3 months ago (2014-09-18 02:45:32 UTC) #1
mattm
https://codereview.chromium.org/584433002/diff/40001/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc File chrome/browser/safe_browsing/safe_browsing_blocking_page.cc (right): https://codereview.chromium.org/584433002/diff/40001/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc#newcode567 chrome/browser/safe_browsing/safe_browsing_blocking_page.cc:567: NOTREACHED(); remove this default case too? https://codereview.chromium.org/584433002/diff/40001/chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc File chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc ...
6 years, 3 months ago (2014-09-19 21:28:16 UTC) #2
felt
https://codereview.chromium.org/584433002/diff/40001/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc File chrome/browser/safe_browsing/safe_browsing_blocking_page.cc (right): https://codereview.chromium.org/584433002/diff/40001/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc#newcode567 chrome/browser/safe_browsing/safe_browsing_blocking_page.cc:567: NOTREACHED(); On 2014/09/19 21:28:16, mattm wrote: > remove this ...
6 years, 2 months ago (2014-09-22 16:42:16 UTC) #3
felt
asvitkine@, can you please review histograms.xml
6 years, 2 months ago (2014-09-22 16:42:55 UTC) #5
Alexei Svitkine (slow)
lgtm
6 years, 2 months ago (2014-09-22 16:45:37 UTC) #6
mattm
lgtm
6 years, 2 months ago (2014-09-22 19:40:50 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/584433002/80001
6 years, 2 months ago (2014-09-22 19:57:29 UTC) #9
commit-bot: I haz the power
Committed patchset #5 (id:80001) as 2fbb0270df0c3ec1e92591ce1ab321f97805f669
6 years, 2 months ago (2014-09-22 20:28:08 UTC) #10
commit-bot: I haz the power
6 years, 2 months ago (2014-09-22 20:28:55 UTC) #11
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/7f383143f3116d8b3ce4a148ebb99e60aeb64c0e
Cr-Commit-Position: refs/heads/master@{#296039}

Powered by Google App Engine
This is Rietveld 408576698