tools/metrics/histograms/histograms.xml - Issue 584433002: Add UI for the new harmful download warning

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/metrics/histograms/histograms.xml

Side-by-side diff isn't available for this file because of its large size.

Issue 584433002: Add UI for the new harmful download warning (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add histograms to histograms.xml Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/metrics/histograms/histograms.xml

diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml

index 96f84dfbc4771674bdd54d4a1a4cd39369c16b5b..0ffc1e9d2f49e00fe5a08366fd779934d569b21b 100644

--- a/tools/metrics/histograms/histograms.xml

+++ b/tools/metrics/histograms/histograms.xml

@@ -10453,6 +10453,22 @@ Therefore, the affected-histogram name has to have at least one dot in it.

</summary>

</histogram>

+<histogram name="interstitial.harmful.decision" enum="SB3InterstitialDecision">

+ <owner>felt@chromium.org</owner>

+ <summary>

+ User decision when presented with a Safe Browsing harmful program

+ interstitial.

+ </summary>

+</histogram>

+<histogram name="interstitial.harmful.interaction"

+ enum="SB3InterstitialInteraction">

+ <owner>felt@chromium.org</owner>

+ <summary>

+ User interactions with a Safe Browsing harmful download interstitial.

mattm 2014/09/19 21:28:16 use same language in both? ("harmful program inter

felt 2014/09/22 16:42:16 Done.

+ </summary>

+</histogram>

<owner>felt@chromium.org</owner>