Stricter default RequestMediaAccessPermission and CheckMediaAccessPermission implementations

content/public/browser/web_contents_delegate.cc

Index: content/public/browser/web_contents_delegate.cc
diff --git a/content/public/browser/web_contents_delegate.cc b/content/public/browser/web_contents_delegate.cc
index 72cabb4b62f5bff36c8bd7276506c702f76bf238..4001c742a19908e28816ebeb48f992286979cc45 100644
--- a/content/public/browser/web_contents_delegate.cc
+++ b/content/public/browser/web_contents_delegate.cc
@@ -164,8 +164,9 @@ void WebContentsDelegate::RequestMediaAccessPermission(
     WebContents* web_contents,
     const MediaStreamRequest& request,
     const MediaResponseCallback& callback) {
+  NOTREACHED();

[jam, 2014/09/24 20:50:04]

here and in the other file, adding a notreached goes against the conventions
we've used everywhere else.the point is that an embedder can take content, and
within a few lines of code embed it. not every feature will work. you can add a
LOG(ERROR). but having dcheck or check run is not something we want

[Henrik Grunell, 2014/09/25 18:28:38]

Done.

   callback.Run(MediaStreamDevices(),
-               MEDIA_DEVICE_INVALID_STATE,
+               MEDIA_DEVICE_NOT_SUPPORTED,
                scoped_ptr<MediaStreamUI>());
 }
 
@@ -173,8 +174,7 @@ bool WebContentsDelegate::CheckMediaAccessPermission(
     WebContents* web_contents,
     const GURL& security_origin,
     MediaStreamType type) {
-  DCHECK(type == MEDIA_DEVICE_AUDIO_CAPTURE ||
-         type == MEDIA_DEVICE_VIDEO_CAPTURE);
+  NOTREACHED();
   return false;
 }