Stricter default RequestMediaAccessPermission and CheckMediaAccessPermission implementations

content/public/browser/web_contents_delegate.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/public/browser/web_contents_delegate.h"
 
 #include "base/compiler_specific.h"
 #include "base/logging.h"
 #include "base/memory/singleton.h"
 #include "content/public/browser/render_view_host.h"
@@ skipping 146 matching lines @@
     WebContents* web_contents,
     SkColor color,
     const std::vector<ColorSuggestion>& suggestions) {
   return NULL;
 }
 
 void WebContentsDelegate::RequestMediaAccessPermission(
     WebContents* web_contents,
     const MediaStreamRequest& request,
     const MediaResponseCallback& callback) {
+  NOTREACHED();

[jam, 2014/09/24 20:50:04]

here and in the other file, adding a notreached goes against the conventions
we've used everywhere else.the point is that an embedder can take content, and
within a few lines of code embed it. not every feature will work. you can add a
LOG(ERROR). but having dcheck or check run is not something we want

[Henrik Grunell, 2014/09/25 18:28:38]

Done.

   callback.Run(MediaStreamDevices(),
-               MEDIA_DEVICE_INVALID_STATE,
+               MEDIA_DEVICE_NOT_SUPPORTED,
                scoped_ptr<MediaStreamUI>());
 }
 
 bool WebContentsDelegate::CheckMediaAccessPermission(
     WebContents* web_contents,
     const GURL& security_origin,
     MediaStreamType type) {
-  DCHECK(type == MEDIA_DEVICE_AUDIO_CAPTURE ||
-         type == MEDIA_DEVICE_VIDEO_CAPTURE);
+  NOTREACHED();
   return false;
 }
 
 bool WebContentsDelegate::RequestPpapiBrokerPermission(
     WebContents* web_contents,
     const GURL& url,
     const base::FilePath& plugin_path,
     const base::Callback<void(bool)>& callback) {
   return false;
 }
@@ skipping 19 matching lines @@
 gfx::Size WebContentsDelegate::GetSizeForNewRenderView(
    WebContents* web_contents) const {
   return gfx::Size();
 }
 
 bool WebContentsDelegate::IsNeverVisible(WebContents* web_contents) {
   return false;
 }
 
 }  // namespace content