[Telemetry] Print trace counters with trace events.

[Telemetry] Print trace counters with trace events.

BUG=
R=ernstm@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233076

[hartmanng, 2013-11-04 21:45:22]

Hi Manfred, I was trying to gather some information in the smoothness benchmark
last week through trace counters, but when I specify --metric=timeline, it seems
like it's only currently spitting out the trace _events_ (ie, timed intervals).

If there's an existing way to do that, let me know, but otherwise I managed to
put together a relatively simple patch to accomplish what I need (and can
hopefully be useful to others as well).

Please take a look.

[ernstm, 2013-11-04 22:25:12]

You are right, timeline metric currently only support trace events, not trace
counters. Except for the unit of the counters, this patch LGTM.

[ernstm, 2013-11-04 22:25:21]

https://codereview.chromium.org/58423002/diff/1/tools/perf/metrics/timeline.py
File tools/perf/metrics/timeline.py (right):

https://codereview.chromium.org/58423002/diff/1/tools/perf/metrics/timeline.p...
tools/perf/metrics/timeline.py:80: results.Add(counter_name, '', total)
Please use 'count' instead of '' for the unit in lines 80 and 81.

[hartmanng, 2013-11-05 14:28:44]

Thanks!

https://codereview.chromium.org/58423002/diff/1/tools/perf/metrics/timeline.py
File tools/perf/metrics/timeline.py (right):

https://codereview.chromium.org/58423002/diff/1/tools/perf/metrics/timeline.p...
tools/perf/metrics/timeline.py:80: results.Add(counter_name, '', total)
On 2013/11/04 22:25:22, Manfred Ernst wrote:
> Please use 'count' instead of '' for the unit in lines 80 and 81.

Done.

[commit-bot: I haz the power, 2013-11-05 14:29:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hartmanng@chromium.org/58423002/70001

[commit-bot: I haz the power, 2013-11-05 16:34:58]

Retried try job too often on linux_rel for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[commit-bot: I haz the power, 2013-11-05 16:40:41]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hartmanng@chromium.org/58423002/70001

[commit-bot: I haz the power, 2013-11-05 16:44:04]

Step "update" is always a major failure.
Look at the try server FAQ for more details.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[commit-bot: I haz the power, 2013-11-05 17:46:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hartmanng@chromium.org/58423002/70001

[commit-bot: I haz the power, 2013-11-05 20:22:03]

Retried try job too often on linux_rel for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[hartmanng, 2013-11-05 20:34:50]

Committed patchset #2 manually as r233076 (presubmit successful).