tools/perf/metrics/timeline.py - Issue 58423002: [Telemetry] Print trace counters with trace events.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tools/perf/metrics/timeline.py

Issue 58423002: [Telemetry] Print trace counters with trace events. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 # Copyright 2013 The Chromium Authors. All rights reserved.	1 # Copyright 2013 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4 import collections	4 import collections

5	5

6 from metrics import Metric	6 from metrics import Metric

7 from telemetry.page import page_measurement	7 from telemetry.page import page_measurement

8	8

9 TRACING_MODE = 'tracing-mode'	9 TRACING_MODE = 'tracing-mode'

10 TIMELINE_MODE = 'timeline-mode'	10 TIMELINE_MODE = 'timeline-mode'

(...skipping 55 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
66 for e in events:	66 for e in events:

67 events_by_name[e.name].append(e)	67 events_by_name[e.name].append(e)

68	68

69 for event_name, event_group in events_by_name.iteritems():	69 for event_name, event_group in events_by_name.iteritems():

70 times = [event.self_time for event in event_group]	70 times = [event.self_time for event in event_group]

71 total = sum(times)	71 total = sum(times)

72 biggest_jank = max(times)	72 biggest_jank = max(times)

73 results.Add(event_name, 'ms', total)	73 results.Add(event_name, 'ms', total)

74 results.Add(event_name + '_max', 'ms', biggest_jank)	74 results.Add(event_name + '_max', 'ms', biggest_jank)

75 results.Add(event_name + '_avg', 'ms', total / len(times))	75 results.Add(event_name + '_avg', 'ms', total / len(times))

	76

	77 counters_by_name = self._thread_for_tab.parent.counters

	78 for counter_name, counter in counters_by_name.iteritems():

	79 total = sum(counter.totals)

	80 results.Add(counter_name, '', total)
	ernstm 2013/11/04 22:25:22 Please use 'count' instead of '' for the unit in l Please use 'count' instead of '' for the unit in lines 80 and 81. hartmanng 2013/11/05 14:28:45 Done. Show quoted text On 2013/11/04 22:25:22, Manfred Ernst wrote: > Please use 'count' instead of '' for the unit in lines 80 and 81. Done.
	81 results.Add(counter_name + '_avg', '', total / len(counter.totals))

OLD	NEW

« no previous file with comments | « no previous file | no next file » | no next file with comments »