Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Unified Diff: win8/viewer/metro_viewer_process_host.h

Issue 584213002: Only do aggressive metro viewer termination in tests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: comment Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: win8/viewer/metro_viewer_process_host.h
diff --git a/win8/viewer/metro_viewer_process_host.h b/win8/viewer/metro_viewer_process_host.h
index 19e9627deac9e610f052468b69531f1045631445..333e3329a511015a1dd7c31e33eb58c9696dacc4 100644
--- a/win8/viewer/metro_viewer_process_host.h
+++ b/win8/viewer/metro_viewer_process_host.h
@@ -70,6 +70,11 @@ class METRO_VIEWER_EXPORT MetroViewerProcessHost : public IPC::Listener,
bool LaunchViewerAndWaitForConnection(
const base::string16& app_user_model_id);
+ // Same as above, except flags that we're launching for running tests. This
+ // causes more aggressive termination when shutting down the viewer.
+ bool LaunchViewerAndWaitForConnectionForTests(
+ const base::string16& app_user_model_id);
+
// Handles the activate desktop command for Metro Chrome Ash. The |ash_exit|
// parameter indicates whether the Ash process would be shutdown after
// activating the desktop.
@@ -208,6 +213,11 @@ class METRO_VIEWER_EXPORT MetroViewerProcessHost : public IPC::Listener,
SelectFolderCompletion select_folder_completion_callback_;
FileSelectionCanceled failure_callback_;
+ // Whether LaunchViewerAndWaitForConnection was for test binaries. In tests,
+ // we are more aggressive in terminating the viewer so that it can
+ // immediately be relaunched for the next test.
+ bool launched_for_test_;
+
DISALLOW_COPY_AND_ASSIGN(MetroViewerProcessHost);
};

Powered by Google App Engine
This is Rietveld 408576698