win8/metro_driver/chrome_app_view_ash.cc - Issue 584213002: Only do aggressive metro viewer termination in tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: win8/metro_driver/chrome_app_view_ash.cc

Issue 584213002: Only do aggressive metro viewer termination in tests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: comment Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: win8/metro_driver/chrome_app_view_ash.cc

diff --git a/win8/metro_driver/chrome_app_view_ash.cc b/win8/metro_driver/chrome_app_view_ash.cc

index 991857dfc9620495015c5807b853613deb74260e..db2d9f30c4e66cfdd04b7b275fae33bde260a6c4 100644

--- a/win8/metro_driver/chrome_app_view_ash.cc

+++ b/win8/metro_driver/chrome_app_view_ash.cc

@@ -970,9 +970,6 @@ void ChromeAppViewAsh::OnMetroExit(MetroTerminateMethod method) {

globals.app_exit->Exit();

}

- // Try really hard, see http://crbug.com/411147 for details.

- ::TerminateProcess(::GetCurrentProcess(), 0);

}

void ChromeAppViewAsh::OnInputSourceChanged() {

« ash/test/ash_test_base.cc ('K') | « ash/test/ash_test_base.cc ('k') | win8/viewer/metro_viewer_process_host.h » ('j') | win8/viewer/metro_viewer_process_host.cc » ('J')