Issue 5840004: nl80211: Set cipher suites when using user space SME

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5840004: nl80211: Set cipher suites when using user space SME (Closed)

Created:
10 years ago by Sam Leffler

Modified:
9 years, 7 months ago

Reviewers:
rtc, Nathan Williams

CC:
chromium-os-reviews_chromium.org

Base URL:
ssh://git@gitrw.chromium.org:9222/hostap.git@0.9.130.B

Visibility:
Public.

Description

nl80211: Set cipher suites when using user space SME Previously, pairwise and group cipher suites were configured only when kernel SME (nl80211 connect API) was used. However, mac80211 needs this information even in the user space SME case for one thing: to disable HT when TKIP/WEP is used. Add NL80211_ATTR_CIPHER_SUITES_PAIRWISE to fix this special case with user space SME. This allows mac80211 to disable HT properly when the AP is configured with configuration that is not allowed. BUG=chromium-os:10249 TEST=new SecMat tests TBA Review URL: http://codereview.chromium.org/5829001 Change-Id: I61995db1c7b45b0e6becea54bf3057c3718329fd (cherry picked from commit 98cd8497d6229b37ee2a7125f70a637c81f1be30) Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=c975b87

Patch Set 1 #

Created: 10 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+46 lines, -0 lines)			Patch
	M	src/drivers/driver_nl80211.c	View		1 chunk	+44 lines, -0 lines	0 comments	Download
	M	wpa_supplicant/sme.c	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Nathan Williams

10 years ago (2010-12-17 19:19:53 UTC) #2

The change LGTM, recognizing that it's already in ToT, but I'm not a branch
gatekeeper. Adding rtc.

Expand Messages | Collapse Messages