Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2312)

Unified Diff: Source/platform/text/BidiResolver.h

Issue 58383002: Update BidiResolver's max level depth to 125 per tr9r29 (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/platform/text/BidiContext.h ('k') | Source/platform/text/BidiResolverTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/platform/text/BidiResolver.h
diff --git a/Source/platform/text/BidiResolver.h b/Source/platform/text/BidiResolver.h
index cc5eb275720c30ebb5ea1db50dd117418916e6d0..5a83b2ecb851e496cee98f5f802ae44cb7c3a1d4 100644
--- a/Source/platform/text/BidiResolver.h
+++ b/Source/platform/text/BidiResolver.h
@@ -433,7 +433,7 @@ bool BidiResolver<Iterator, Run>::commitExplicitEmbedding()
level = nextGreaterOddLevel(level);
else
level = nextGreaterEvenLevel(level);
- if (level < 61)
+ if (level < BidiContext::kMaxLevel)
toContext = BidiContext::create(level, direction, override, embedding.source(), toContext.get());
}
}
@@ -497,7 +497,7 @@ inline void BidiResolver<Iterator, Run>::updateStatusLastFromCurrentDirection(WT
template <class Iterator, class Run>
inline void BidiResolver<Iterator, Run>::reorderRunsFromLevels()
{
- unsigned char levelLow = 128;
+ unsigned char levelLow = 128; // Should this be BidiContext::kMaxLevel + 1?
leviw_travelin_and_unemployed 2013/11/04 20:24:57 It certainly looks like it should. Would you mind
eseidel 2013/11/04 20:47:43 Done.
unsigned char levelHigh = 0;
for (Run* run = m_runs.firstRun(); run; run = run->next()) {
levelHigh = std::max(run->level(), levelHigh);
« no previous file with comments | « Source/platform/text/BidiContext.h ('k') | Source/platform/text/BidiResolverTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698