DescriptionUpdate BidiResolver's max level depth to 125 per tr9r29
This is mostly just to demonstrate the process of making
a change to BidiResolver and using the new BidiTest.txt
based testing in BidiResolverTest.cpp.
Our test failures are now:
WARNING: Skipped 418143 tests.
Ran 352098 tests: 44882 level failures 19151 order failures.
Which is down 7 level failures from before and 2 order failures.
The process to test this was:
curl -O http://www.unicode.org/Public/UNIDATA/BidiTest.txt
(The version in our tree is older, BidiTest.txt needs to be
in your working directory for the BidiTest.txt based tests to run.)
ninja -C out/Debug blink_platform_unittests
./out/Debug/blink_platform_unittests
And then I adjusted the EXPECT_EQ to have the new (lower) numbers.
I also flipped the order of arguments in the EXPECT_EQ calls
so that the expected/actual numbers are printed correctly on failure.
BUG=242238
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=161290
Patch Set 1 #
Total comments: 2
Patch Set 2 : Updated per leviw's review #
Messages
Total messages: 5 (0 generated)
|