Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Issue 583793002: Properly escape goma dir on windows (Closed)

Created:
6 years, 3 months ago by sullivan
Modified:
6 years, 3 months ago
Reviewers:
qyearsley
CC:
chromium-reviews, prasadv, tonyg, RyanS
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Properly escape goma dir on windows. Fixes errors in goma path. BUG=394990 Committed: https://crrev.com/9d4ff75568bccbb9fe9ac1163a7ab4e7ba6bf5f5 Cr-Commit-Position: refs/heads/master@{#295704}

Patch Set 1 #

Patch Set 2 : Removed printfs and bisect config changes #

Patch Set 3 : Removed another printf #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M tools/auto_bisect/builder.py View 1 2 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 9 (2 generated)
qyearsley
Excellent! Maybe you could submit this CL (minus the print statements and change to run-perf-test.cfg) ...
6 years, 3 months ago (2014-09-18 21:51:00 UTC) #2
sullivan
Here is a successful try job using this patch: http://build.chromium.org/p/tryserver.chromium.perf/builders/win_8_perf_bisect/builds/177 IIUC, windows bisects have only ...
6 years, 3 months ago (2014-09-18 23:17:54 UTC) #3
sullivan
This is ready for review.
6 years, 3 months ago (2014-09-18 23:18:21 UTC) #4
qyearsley
This change LGTM; when I run `print "C:\\b\\build\\goma".encode("string_escape")` in the interpreter, I get "C:\\b\\build\\goma" as ...
6 years, 3 months ago (2014-09-19 07:16:22 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/583793002/40001
6 years, 3 months ago (2014-09-19 13:38:02 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001) as 5d4d16a7711a8dd3f70f09c52cfd42d7c88f11e1
6 years, 3 months ago (2014-09-19 14:34:57 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-19 14:35:43 UTC) #9
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/9d4ff75568bccbb9fe9ac1163a7ab4e7ba6bf5f5
Cr-Commit-Position: refs/heads/master@{#295704}

Powered by Google App Engine
This is Rietveld 408576698