tools/auto_bisect/builder.py - Issue 583793002: Properly escape goma dir on windows

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/auto_bisect/builder.py

Issue 583793002: Properly escape goma dir on windows (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Removed another printf Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/auto_bisect/builder.py

diff --git a/tools/auto_bisect/builder.py b/tools/auto_bisect/builder.py

index f039a57e5d988449cc9d4782ea0c9e51e90637a0..6b530f78ac133576640cda54f9462cbcb8404206 100644

--- a/tools/auto_bisect/builder.py

+++ b/tools/auto_bisect/builder.py

@@ -40,7 +40,8 @@ class Builder(object):

'Path to visual studio could not be determined.')

else:

SetBuildSystemDefault(opts.build_preference, opts.use_goma,

- opts.goma_dir)

+ # Need to re-escape goma dir, see crbug.com/394990

+ opts.goma_dir.encode('string_escape'))

else:

if not opts.build_preference:

if 'ninja' in os.getenv('GYP_GENERATORS', default=''):

« no previous file with comments | « no previous file | no next file » | no next file with comments »