Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Issue 583783002: Switch PNaCl lib, include, and translator directories for new layout (Closed)

Created:
6 years, 3 months ago by Derek Schuff
Modified:
6 years, 3 months ago
CC:
native-client-reviews_googlegroups.com
Project:
nacl
Visibility:
Public.

Description

Switch PNaCl lib, include, and translator directories for new layout This makes the directory layout more like a standard gnu-style toolchain and more suitable for support of multiple architectures, which will be used in direct-to-nacl mode. For now, since the biased bitcode builds will have to be around until direct-to-nacl mode can replace them, they are included in the same scheme as if they were their own architectures. For now the directories used by the translator (the "native libs" and translator nexes) have a similar layout to before except that they all move into the translator/ directory. The changes to the bitcode lib builds should also make it easier to reuse them for direct-to-nacl mode if desired. R=jvoung@chromium.org, noelallen@chromium.org BUG= https://code.google.com/p/nativeclient/issues/detail?id=3946 Committed: https://src.chromium.org/viewvc/native_client?view=rev&revision=13764

Patch Set 1 #

Patch Set 2 : separate compiler-owned libs #

Patch Set 3 : cleanup #

Patch Set 4 : typo #

Total comments: 6

Patch Set 5 : review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -90 lines) Patch
M pnacl/build.sh View 1 2 3 4 3 chunks +15 lines, -8 lines 0 comments Download
M pnacl/driver/driver_env.py View 1 2 3 4 1 chunk +25 lines, -23 lines 0 comments Download
M pnacl/driver/pnacl-driver.py View 1 1 chunk +1 line, -1 line 0 comments Download
M pnacl/driver/pnacl-translate.py View 1 1 chunk +1 line, -1 line 0 comments Download
M site_scons/site_tools/naclsdk.py View 1 chunk +2 lines, -2 lines 0 comments Download
M toolchain_build/pnacl_targetlibs.py View 1 2 14 chunks +65 lines, -54 lines 0 comments Download
M toolchain_build/toolchain_build_pnacl.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
Derek Schuff
6 years, 3 months ago (2014-09-18 23:21:08 UTC) #2
jvoung (off chromium)
https://codereview.chromium.org/583783002/diff/60001/pnacl/build.sh File pnacl/build.sh (right): https://codereview.chromium.org/583783002/diff/60001/pnacl/build.sh#newcode1990 pnacl/build.sh:1990: case $1 in local arch? https://codereview.chromium.org/583783002/diff/60001/pnacl/driver/driver_env.py File pnacl/driver/driver_env.py (right): ...
6 years, 3 months ago (2014-09-19 16:29:03 UTC) #3
Derek Schuff
https://codereview.chromium.org/583783002/diff/60001/pnacl/build.sh File pnacl/build.sh (right): https://codereview.chromium.org/583783002/diff/60001/pnacl/build.sh#newcode1990 pnacl/build.sh:1990: case $1 in On 2014/09/19 16:29:02, jvoung wrote: > ...
6 years, 3 months ago (2014-09-19 16:39:48 UTC) #4
jvoung (off chromium)
lgtm
6 years, 3 months ago (2014-09-19 20:13:00 UTC) #5
Derek Schuff
6 years, 3 months ago (2014-09-19 20:21:35 UTC) #6
Message was sent while issue was closed.
Committed patchset #5 (id:80001) manually as 13764 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698