Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 583773004: Revert of introduce Props to surface (Closed)

Created:
6 years, 3 months ago by reed2
Modified:
6 years, 3 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Revert of introduce Props to surface (patchset #27 id:520001 of https://codereview.chromium.org/551463004/) Reason for revert: Broke call site in WebKit Original issue's description: > introduce Props to surface (work in progress) > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/3716fd067a5621bb94a6cb08d72afec8bf3aceda TBR=robertphillips@google.com,bsalomon@google.com,jvanverth@google.com,bungeman@google.com,fmalita@google.com,vangelis@chromium.org,reed@google.com NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/29c857d0f3a1cb837f73406eeb6ba9771879b5e7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+256 lines, -614 lines) Patch
M debugger/QT/SkGLWidget.cpp View 2 chunks +2 lines, -4 lines 0 comments Download
M dm/DMGpuSupport.h View 1 chunk +1 line, -1 line 0 comments Download
M gm/dftext.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M gm/image.cpp View 1 chunk +1 line, -1 line 0 comments Download
D gm/surface.cpp View 1 chunk +0 lines, -109 lines 0 comments Download
M gm/xfermodes3.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M gyp/gmslides.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M include/core/SkBitmapDevice.h View 1 chunk +1 line, -1 line 0 comments Download
M include/core/SkCanvas.h View 5 chunks +5 lines, -18 lines 0 comments Download
M include/core/SkDevice.h View 2 chunks +1 line, -3 lines 0 comments Download
M include/core/SkSurface.h View 7 chunks +34 lines, -57 lines 0 comments Download
D include/core/SkSurfaceProps.h View 1 chunk +0 lines, -80 lines 0 comments Download
M include/pdf/SkPDFDevice.h View 1 chunk +1 line, -1 line 0 comments Download
M include/utils/SkNoSaveLayerCanvas.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/core/SkBitmapDevice.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/core/SkCanvas.cpp View 17 chunks +22 lines, -68 lines 0 comments Download
M src/core/SkDevice.cpp View 2 chunks +2 lines, -6 lines 0 comments Download
M src/core/SkDeviceProperties.h View 1 chunk +92 lines, -15 lines 0 comments Download
M src/core/SkPaint.cpp View 2 chunks +12 lines, -26 lines 0 comments Download
M src/core/SkPictureRecord.h View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkPictureRecord.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkRecorder.h View 1 chunk +1 line, -1 line 0 comments Download
D src/core/SkSurfacePriv.h View 1 chunk +0 lines, -25 lines 0 comments Download
M src/gpu/GrDistanceFieldTextContext.cpp View 3 chunks +5 lines, -4 lines 0 comments Download
M src/gpu/GrLayerHoister.cpp View 2 chunks +4 lines, -2 lines 0 comments Download
M src/gpu/SkGpuDevice.h View 3 chunks +4 lines, -5 lines 0 comments Download
M src/gpu/SkGpuDevice.cpp View 5 chunks +10 lines, -12 lines 0 comments Download
M src/image/SkSurface.cpp View 4 chunks +6 lines, -99 lines 0 comments Download
M src/image/SkSurface_Base.h View 1 chunk +3 lines, -4 lines 0 comments Download
M src/image/SkSurface_Gpu.cpp View 6 chunks +13 lines, -18 lines 0 comments Download
M src/image/SkSurface_Raster.cpp View 6 chunks +13 lines, -16 lines 0 comments Download
M src/pdf/SkPDFDevice.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/ports/SkImageDecoder_CG.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M src/utils/SkDeferredCanvas.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M tests/DeferredCanvasTest.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M tests/GpuDrawPathTest.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M tests/ImageFilterTest.cpp View 4 chunks +0 lines, -6 lines 0 comments Download
M tests/PremulAlphaRoundTripTest.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M tests/ReadWriteAlphaTest.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M tests/ResourceCacheTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/SurfaceTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tools/PictureRenderer.cpp View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
reed2
Created Revert of introduce Props to surface
6 years, 3 months ago (2014-09-21 17:23:24 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/583773004/1
6 years, 3 months ago (2014-09-21 17:24:16 UTC) #2
commit-bot: I haz the power
6 years, 3 months ago (2014-09-21 17:25:13 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as 29c857d0f3a1cb837f73406eeb6ba9771879b5e7

Powered by Google App Engine
This is Rietveld 408576698