Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(788)

Issue 583753002: Fix yasm_assemble.gni (Closed)

Created:
6 years, 3 months ago by piman
Modified:
6 years, 3 months ago
Reviewers:
Alpha Left Google
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix yasm_assemble.gni Change #294679 was lost in #294932 BUG=None Committed: https://crrev.com/1edae36d2b9bbf4010fa3cc387e588132197361b Cr-Commit-Position: refs/heads/master@{#295567}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M third_party/yasm/yasm_assemble.gni View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
piman
6 years, 3 months ago (2014-09-18 20:17:38 UTC) #2
Alpha Left Google
lgtm
6 years, 3 months ago (2014-09-18 20:54:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/583753002/1
6 years, 3 months ago (2014-09-18 21:09:51 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 0ab1d8fbbe619a655dfb25aa1f48ddac6b4428eb
6 years, 3 months ago (2014-09-18 21:53:25 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-18 21:54:04 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1edae36d2b9bbf4010fa3cc387e588132197361b
Cr-Commit-Position: refs/heads/master@{#295567}

Powered by Google App Engine
This is Rietveld 408576698