[Android] Invalidate ChromeShell progress bar during animation

[Android] Invalidate ChromeShell progress bar during animation

View invalidations outside of animation can stall the Chrome message
loop. Avoid such stalls during page load by synchronizing all
ChromeShell progress drawable updates with View animation.

BUG=414674
Committed: https://crrev.com/57fbc869bf82f08f516c9d478bfc04830d03ffa9
Cr-Commit-Position: refs/heads/master@{#295604}

[jdduke (slow), 2014-09-18 16:08:00]

jdduke@chromium.org changed reviewers:
+ nyquist@chromium.org

[jdduke (slow), 2014-09-18 16:08:01]

nyquist@: PTAL, thanks.

[nyquist, 2014-09-18 21:43:24]

https://codereview.chromium.org/583673002/diff/20001/chrome/android/shell/jav...
File
chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellToolbar.java
(right):

https://codereview.chromium.org/583673002/diff/20001/chrome/android/shell/jav...
chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellToolbar.java:107:
removeCallbacks(mClearProgressRunnable);
Should this stay here or move to the other update progress runnable? It feels a
bit unbalanced, but it might just be me.

[jdduke (slow), 2014-09-18 21:59:22]

https://codereview.chromium.org/583673002/diff/20001/chrome/android/shell/jav...
File
chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellToolbar.java
(right):

https://codereview.chromium.org/583673002/diff/20001/chrome/android/shell/jav...
chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellToolbar.java:107:
removeCallbacks(mClearProgressRunnable);
On 2014/09/18 21:43:23, nyquist wrote:
> Should this stay here or move to the other update progress runnable? It feels
a
> bit unbalanced, but it might just be me.

I think it can go there, but then we might have a scenario where both callbacks
are scheduled during the same animation callback, so it could be doing extra
setLevel work. I don't have a strong opinion though, up to you.

[nyquist, 2014-09-18 22:03:04]

lgtm

[jdduke (slow), 2014-09-18 22:06:48]

The CQ bit was checked by jdduke@chromium.org

[commit-bot: I haz the power, 2014-09-18 22:08:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/583673002/20001

[commit-bot: I haz the power, 2014-09-18 23:40:43]

Committed patchset #2 (id:20001) as 312dea8f5bd519aa3acf43ca297a140cd1226881

[commit-bot: I haz the power, 2014-09-18 23:41:22]

Patchset 2 (id:??) landed as
https://crrev.com/57fbc869bf82f08f516c9d478bfc04830d03ffa9
Cr-Commit-Position: refs/heads/master@{#295604}