[Mac] Remove unnecessary button on 'Bookmark all tabs' window

[Mac] Remove unnecessary button on 'Bookmark all tabs' window

Remove unnecessary button on 'Bookmark all tabs' window which appears
before "Bookmarks Bar"
XIB Changes:
Removing the line in the following .xib file which is responsible for the appearance of empty button.
chrome/app/nibs/BookmarkAllTabs.xib

BUG=415554
R=asvitkine@chromium.org

TEST=
1) Launch chrome, open 2-3 tabs.
2) Right click on last tab and select 'Bookmark all tabs'
3) Empty button shouldn't be shown.

Committed: https://crrev.com/0ce925fc1ee0f53142313d1b63b32dafbeeeaace
Cr-Commit-Position: refs/heads/master@{#295714}

[shilpa.shri, 2014-09-18 13:47:55]

PTAL

[Alexei Svitkine (slow), 2014-09-18 14:38:30]

Please provide a screenshot of how it looks like after the fix and also add a
XIB Changes: section to your CL description.

[shilpa.shri, 2014-09-19 06:45:45]

On 2014/09/18 14:38:30, Alexei Svitkine wrote:
> Please provide a screenshot of how it looks like after the fix and also add a
> XIB Changes: section to your CL description.

Thanks for response.
Modified CL description and added screenshot in the issue detail
(http://code.google.com/p/chromium/issues/detail?id=415554#c4)

[Alexei Svitkine (slow), 2014-09-19 14:11:03]

lgtm

[shilpa.shri, 2014-09-19 14:54:55]

The CQ bit was checked by shilpa.shri@samsung.com

[commit-bot: I haz the power, 2014-09-19 14:56:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/583633002/20001

[commit-bot: I haz the power, 2014-09-19 15:53:29]

Committed patchset #2 (id:20001) as 4daf2780f8a9ed92d59ac48588f3b73727a33380

[commit-bot: I haz the power, 2014-09-19 15:54:11]

Patchset 2 (id:??) landed as
https://crrev.com/0ce925fc1ee0f53142313d1b63b32dafbeeeaace
Cr-Commit-Position: refs/heads/master@{#295714}

[Avi (use Gerrit), 2014-09-22 15:47:51]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/592833002/ by avi@chromium.org.

The reason for reverting is: Nonono you can't just hack out lines from xib
files! https://codereview.chromium.org/586543002/ rebuilds the xib file in Xcode
to accomplish this and more..

[Avi (use Gerrit), 2014-09-22 15:52:43]

On 2014/09/22 15:47:51, Avi wrote:
> A revert of this CL (patchset #2 id:20001) has been created in
> https://codereview.chromium.org/592833002/ by mailto:avi@chromium.org.
> 
> The reason for reverting is: Nonono you can't just hack out lines from xib
> files! https://codereview.chromium.org/586543002/ rebuilds the xib file in
Xcode
> to accomplish this and more..

In the future, you MUST follow the directions for editing XIB files found at
http://www.chromium.org/developers/design-documents/mac-xib-files . If all you
need to edit is some button text, sure, go and hack the xml directly. Otherwise,
please don't attempt to do it by hand.