Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(354)

Issue 583633002: [Mac] Remove unnecessary button on 'Bookmark all tabs' window (Closed)

Created:
6 years, 3 months ago by shilpa.shri
Modified:
6 years, 3 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[Mac] Remove unnecessary button on 'Bookmark all tabs' window Remove unnecessary button on 'Bookmark all tabs' window which appears before "Bookmarks Bar" XIB Changes: Removing the line in the following .xib file which is responsible for the appearance of empty button. chrome/app/nibs/BookmarkAllTabs.xib BUG=415554 R=asvitkine@chromium.org TEST= 1) Launch chrome, open 2-3 tabs. 2) Right click on last tab and select 'Bookmark all tabs' 3) Empty button shouldn't be shown. Committed: https://crrev.com/0ce925fc1ee0f53142313d1b63b32dafbeeeaace Cr-Commit-Position: refs/heads/master@{#295714}

Patch Set 1 #

Patch Set 2 : Adding XIB changes details in CL description. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M AUTHORS View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/app/nibs/BookmarkAllTabs.xib View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 10 (1 generated)
shilpa.shri
PTAL
6 years, 3 months ago (2014-09-18 13:47:55 UTC) #1
Alexei Svitkine (slow)
Please provide a screenshot of how it looks like after the fix and also add ...
6 years, 3 months ago (2014-09-18 14:38:30 UTC) #2
shilpa.shri
On 2014/09/18 14:38:30, Alexei Svitkine wrote: > Please provide a screenshot of how it looks ...
6 years, 3 months ago (2014-09-19 06:45:45 UTC) #3
Alexei Svitkine (slow)
lgtm
6 years, 3 months ago (2014-09-19 14:11:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/583633002/20001
6 years, 3 months ago (2014-09-19 14:56:07 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 4daf2780f8a9ed92d59ac48588f3b73727a33380
6 years, 3 months ago (2014-09-19 15:53:29 UTC) #7
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/0ce925fc1ee0f53142313d1b63b32dafbeeeaace Cr-Commit-Position: refs/heads/master@{#295714}
6 years, 3 months ago (2014-09-19 15:54:11 UTC) #8
Avi (use Gerrit)
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/592833002/ by avi@chromium.org. ...
6 years, 3 months ago (2014-09-22 15:47:51 UTC) #9
Avi (use Gerrit)
6 years, 3 months ago (2014-09-22 15:52:43 UTC) #10
Message was sent while issue was closed.
On 2014/09/22 15:47:51, Avi wrote:
> A revert of this CL (patchset #2 id:20001) has been created in
> https://codereview.chromium.org/592833002/ by mailto:avi@chromium.org.
> 
> The reason for reverting is: Nonono you can't just hack out lines from xib
> files! https://codereview.chromium.org/586543002/ rebuilds the xib file in
Xcode
> to accomplish this and more..

In the future, you MUST follow the directions for editing XIB files found at
http://www.chromium.org/developers/design-documents/mac-xib-files . If all you
need to edit is some button text, sure, go and hack the xml directly. Otherwise,
please don't attempt to do it by hand.

Powered by Google App Engine
This is Rietveld 408576698