Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Unified Diff: chrome/browser/android/most_visited_sites.h

Issue 583623002: Fix WeakPtrFactory member placement (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « AUTHORS ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/android/most_visited_sites.h
diff --git a/chrome/browser/android/most_visited_sites.h b/chrome/browser/android/most_visited_sites.h
index 4a24ad772e2244591cd9f9135638212e5ac06c85..fae9b7936c839b9aa886cf5c73f53e1639cdeea6 100644
--- a/chrome/browser/android/most_visited_sites.h
+++ b/chrome/browser/android/most_visited_sites.h
@@ -119,9 +119,6 @@ class MostVisitedSites : public ProfileSyncServiceObserver,
// Copy of the server suggestions (if enabled). Used for logging.
suggestions::SuggestionsProfile server_suggestions_;
- // For callbacks may be run after destruction.
- base::WeakPtrFactory<MostVisitedSites> weak_ptr_factory_;
-
content::NotificationRegistrar registrar_;
// The source of the Most Visited sites.
@@ -131,6 +128,9 @@ class MostVisitedSites : public ProfileSyncServiceObserver,
};
MostVisitedSource mv_source_;
+ // For callbacks may be run after destruction.
+ base::WeakPtrFactory<MostVisitedSites> weak_ptr_factory_;
+
DISALLOW_COPY_AND_ASSIGN(MostVisitedSites);
};
« no previous file with comments | « AUTHORS ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698