content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java - Issue 583583005: [Contextual Search] Pass selection coordinate to ContentViewClient.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

Issue 583583005: [Contextual Search] Pass selection coordinate to ContentViewClient. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Moving a TODO as per Ted's suggestion Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

diff --git a/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java b/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

index 451a5be5210ec68676ab6be00fd1a99a06e515d4..226d7989bdbde0dff01f6c93f8b8918dab52fe19 100644

--- a/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

+++ b/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

@@ -2021,7 +2021,9 @@ public class ContentViewCore

default:

assert false : "Invalid selection event type.";

}

- getContentViewClient().onSelectionEvent(eventType);

+ final float scale = mRenderCoordinates.getDeviceScaleFactor();

+ getContentViewClient().onSelectionEvent(eventType, posXDip * scale, posYDip * scale);

}

private void hideTextHandles() {

« no previous file with comments | « content/public/android/java/src/org/chromium/content/browser/ContentViewClient.java ('k') | no next file » | no next file with comments »