Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(393)

Unified Diff: content/public/android/java/src/org/chromium/content/browser/ContentViewClient.java

Issue 583583005: [Contextual Search] Pass selection coordinate to ContentViewClient. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Moving a TODO as per Ted's suggestion Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/android/java/src/org/chromium/content/browser/ContentViewClient.java
diff --git a/content/public/android/java/src/org/chromium/content/browser/ContentViewClient.java b/content/public/android/java/src/org/chromium/content/browser/ContentViewClient.java
index c3e4bf091c5203b9174c50ce5585da6514d804eb..8e1f09b4e7651699b54ef05e120ae5ee921691be 100644
--- a/content/public/android/java/src/org/chromium/content/browser/ContentViewClient.java
+++ b/content/public/android/java/src/org/chromium/content/browser/ContentViewClient.java
@@ -131,13 +131,25 @@ public class ContentViewClient {
/**
* Notification that a selection or insertion-related event has occurred.
- * TODO(donnd): Remove this and instead expose a ContextualSearchClient, crbug.com/403001.
+ * TODO(pedrosimonetti): remove this method once downstream code has been updated to use
+ * the other signature.
* @param eventType The selection event type, see {@link SelectionEventType}.
*/
public void onSelectionEvent(int eventType) {
}
/**
+ * Notification that a selection or insertion-related event has occurred.
+ * TODO(donnd): Remove this and instead expose a ContextualSearchClient, crbug.com/403001.
+ * @param eventType The selection event type, see {@link SelectionEventType}.
+ * @param posXPix The x coordinate of the selection start handle.
+ * @param posYPix The y coordinate of the selection start handle.
+ */
+ public void onSelectionEvent(int eventType, float posXPix, float posYPix) {
+ onSelectionEvent(eventType);
+ }
+
+ /**
* Called when a new content intent is requested to be started.
*/
public void onStartContentIntent(Context context, String intentUrl) {
« no previous file with comments | « no previous file | content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698