Files.app: Fix DCHECK in FakeFileSystem.

Files.app: Fix DCHECK in FakeFileSystem.

Previous DCHECK uses IsUnderDriveMountPoint method which takes paths for
external file system. But the paths used in FakeFileSystem are drive paths that
are extracted from external file system paths. So it goes into infinity loop
during traversing parent directory when a path pointing the out of my drive
directory is given.

The CL removes the check, and add util::GetDriveMyDriveRootPath().IsParent(file_path) to
prevent the infinity loop.

BUG=None
TEST=None

Committed: https://crrev.com/bb138d429978b5b0b2b266d91a23538b10673593
Cr-Commit-Position: refs/heads/master@{#296644}

[hirono, 2014-09-18 12:02:38]

hirono@chromium.org changed reviewers:
+ kinaba@chromium.org

[hirono, 2014-09-18 12:02:39]

PTAL the CL? Thank you!

[kinaba, 2014-09-19 01:47:18]

Good catch

https://codereview.chromium.org/583583003/diff/1/chrome/browser/chromeos/driv...
File chrome/browser/chromeos/drive/fake_file_system.cc (right):

https://codereview.chromium.org/583583003/diff/1/chrome/browser/chromeos/driv...
chrome/browser/chromeos/drive/fake_file_system.cc:148:
DCHECK(file_path.BaseName() != file_path);
The condition looks a bit detouring.

What we want to enforce here is that all paths must be under "My Drive",
according to the comment below. Then, what about asserting in that way? For
instance, like putting

DCHECK(util::GetDriveMyDriveRootPath().IsParent(file_path));

after the if branch (an before the GetResourceEntry(file_path.DirName()) call).

[hirono, 2014-09-22 04:53:28]

https://codereview.chromium.org/583583003/diff/1/chrome/browser/chromeos/driv...
File chrome/browser/chromeos/drive/fake_file_system.cc (right):

https://codereview.chromium.org/583583003/diff/1/chrome/browser/chromeos/driv...
chrome/browser/chromeos/drive/fake_file_system.cc:148:
DCHECK(file_path.BaseName() != file_path);
On 2014/09/19 01:47:18, kinaba wrote:
> The condition looks a bit detouring.
> 
> What we want to enforce here is that all paths must be under "My Drive",
> according to the comment below. Then, what about asserting in that way? For
> instance, like putting
> 
> DCHECK(util::GetDriveMyDriveRootPath().IsParent(file_path));
> 
> after the if branch (an before the GetResourceEntry(file_path.DirName())
call).

Let me do this. Thank you!

[kinaba, 2014-09-24 11:36:54]

lgtm

https://codereview.chromium.org/583583003/diff/20001/chrome/browser/chromeos/...
File chrome/browser/chromeos/drive/fake_file_system.cc (right):

https://codereview.chromium.org/583583003/diff/20001/chrome/browser/chromeos/...
chrome/browser/chromeos/drive/fake_file_system.cc:149: // Now, we only support
files under my drive.
nit: I slightly prefer this comment to be moved before the DHECK

[hirono, 2014-09-25 03:55:11]

Thanks!

https://codereview.chromium.org/583583003/diff/20001/chrome/browser/chromeos/...
File chrome/browser/chromeos/drive/fake_file_system.cc (right):

https://codereview.chromium.org/583583003/diff/20001/chrome/browser/chromeos/...
chrome/browser/chromeos/drive/fake_file_system.cc:149: // Now, we only support
files under my drive.
On 2014/09/24 11:36:54, kinaba wrote:
> nit: I slightly prefer this comment to be moved before the DHECK

Done.

[hirono, 2014-09-25 03:55:14]

The CQ bit was checked by hirono@chromium.org

[commit-bot: I haz the power, 2014-09-25 03:56:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/583583003/40001

[commit-bot: I haz the power, 2014-09-25 04:36:17]

Committed patchset #3 (id:40001) as e0dfc6511fa091adb41e828dbd3c2b628bd9fafb

[commit-bot: I haz the power, 2014-09-25 04:37:08]

Patchset 3 (id:??) landed as
https://crrev.com/bb138d429978b5b0b2b266d91a23538b10673593
Cr-Commit-Position: refs/heads/master@{#296644}